Skip to content

Add make actions to replicate CI/CD functionalities#154

Open
todor-ivanov wants to merge 1 commit into
dmwm:masterfrom
todor-ivanov:feature_CICDActionsToMake_fix-153
Open

Add make actions to replicate CI/CD functionalities#154
todor-ivanov wants to merge 1 commit into
dmwm:masterfrom
todor-ivanov:feature_CICDActionsToMake_fix-153

Conversation

@todor-ivanov
Copy link
Copy Markdown
Contributor

Summary

Implements the manual Makefile-driven release flow requested in #153.

This PR adds explicit Make targets for maintainer-controlled image publication and deployment actions that were previously only described in GitHub Actions, including:

  • image upload/publication to registry.cern.ch/cmsweb/dbs2go;
  • stable tag handling for final releases;
  • no-Oracle image upload variants;
  • imagebot-based k8s deployment updates;
  • README documentation for the manual release/upload/deploy procedure.

The intended release flow becomes explicit and locally controlled:

git tag <release-tag>
make upload TAG=<release-tag>
make k8deploy TAG=<release-tag> IMAGEBOT_URL=<imagebot-url>

This addresses the Makefile-side requirements from #153 by making the privileged release operations manually executable through make.

Closes #153.

Copy link
Copy Markdown
Contributor

@vkuznet vkuznet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to separate docker build from push actions.

Comment thread Makefile
curl -ksLO https://raw.githubusercontent.com/dmwm/CMSKubernetes/master/docker/dbs2go/run.sh; \
chmod +x run.sh; \
sed -i -e "s,ENV TAG=.*,ENV TAG=$(TAG),g" Dockerfile; \
docker build . --tag "$(IMAGE):$(TAG)"; \
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Todor, I suggest to separate docker build from docker push since here you don't even check if build was successful. Moreover, sometimes we may prefer to build local image but do not upload it yet to registry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Include all automated CI/CD workflows as possible manualy executable actions through Make

2 participants