Add make actions to replicate CI/CD functionalities#154
Open
todor-ivanov wants to merge 1 commit into
Open
Conversation
vkuznet
requested changes
May 29, 2026
Contributor
vkuznet
left a comment
There was a problem hiding this comment.
I suggest to separate docker build from push actions.
| curl -ksLO https://raw.githubusercontent.com/dmwm/CMSKubernetes/master/docker/dbs2go/run.sh; \ | ||
| chmod +x run.sh; \ | ||
| sed -i -e "s,ENV TAG=.*,ENV TAG=$(TAG),g" Dockerfile; \ | ||
| docker build . --tag "$(IMAGE):$(TAG)"; \ |
Contributor
There was a problem hiding this comment.
Todor, I suggest to separate docker build from docker push since here you don't even check if build was successful. Moreover, sometimes we may prefer to build local image but do not upload it yet to registry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the manual Makefile-driven release flow requested in #153.
This PR adds explicit Make targets for maintainer-controlled image publication and deployment actions that were previously only described in GitHub Actions, including:
registry.cern.ch/cmsweb/dbs2go;The intended release flow becomes explicit and locally controlled:
This addresses the Makefile-side requirements from #153 by making the privileged release operations manually executable through
make.Closes #153.