Counter-announce to non-leader peers to speed up connectivity#164
Merged
dmotz merged 1 commit intodmotz:mainfrom Apr 22, 2026
Merged
Conversation
Owner
|
Thanks! Did some testing and saw this drop the connection time for peers coming later, which is something that's not measured in the existing tests. Will publish this in the next release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Faster discovery by counter-announcing
To prevent race conditions when exchanging WebRTC SDP offers, we compare peer IDs. The lower-ID peer always leads by creating the offer.
This means that when a new lower ID peer joins and announces, the higher ID peer silently ignores. The new joining peer must then wait up to ~5.3 seconds for the higher ID peer's next re-announce before a negotiation for connectivity begins.
This change makes the higher ID peer immediately counter-announce to the lower ID peer's self topic, allowing the connection to begin right away.
Changes