Git provider abstraction to support GitLab later#821
Open
nicolaric wants to merge 3 commits intodlvhdr:mainfrom
Open
Git provider abstraction to support GitLab later#821nicolaric wants to merge 3 commits intodlvhdr:mainfrom
nicolaric wants to merge 3 commits intodlvhdr:mainfrom
Conversation
This establishes the Provider interface and concrete implementations for GitHub (using gh CLI) and GitLab (using glab CLI). The interface defines methods for: - FetchPullRequests/FetchIssues - FetchPullRequest (single PR/MR) - FetchIssueComments - GetCurrentUser - GetCLICommand Also adds --gitlab flag to specify GitLab hostname.
- Add label color caching per project - Improve auth state detection - Fix glab command parsing for various outputs
nicolaric
changed the title
1 task
Owner
|
Let's add the gitlab specific code in a separate PR |
Author
|
@dlvhdr i removed the gitlab specific stuff and will add a new pull request once this one is merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR establishes a provider abstraction layer that enables gh-dash to support both GitHub and GitLab as Git hosting providers. The abstraction decouples the application logic from provider-specific implementations, allowing future providers to be added with minimal changes.
This change is split off from #819 in order to create small parts.
first sub-pr of #819
those changes take care of adding an abstraction layer
Configuration
gitlab-config.yml: Example configuration file for GitLab modecmd/root.go: Adds--gitlab <hostname>flag to enable GitLab modelity.Later PR's will be: