fix: prevent panic when navigating with no sections loaded#817
Merged
dlvhdr merged 1 commit intodlvhdr:mainfrom Mar 27, 2026
Merged
fix: prevent panic when navigating with no sections loaded#817dlvhdr merged 1 commit intodlvhdr:mainfrom
dlvhdr merged 1 commit intodlvhdr:mainfrom
Conversation
Bug: Quickly pressing the “s” key to switch views during startup causes a panic (nil pointer dereference). Cause: Switching to a view whose sections haven’t loaded yet makes getCurrSection() return nil. The Down, Up, FirstLine, LastLine, and Refresh key handlers call methods on currSection without nil checks. Fix: Guard the handlers with a currSection != nil check, matching what dash already does for Search and PrevSection/NextSection. Fixes dlvhdr#812
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: Quickly pressing the s key to switch views during startup causes a panic (nil pointer dereference).
Cause: Switching to a view whose sections haven’t loaded yet makes
getCurrSection()return nil. The Down, Up, FirstLine, LastLine, and Refresh key handlers call methods oncurrSectionwithout nil checks.Fix: Guard the handlers with a
currSection != nilcheck, matching what dash already does for Search and PrevSection/NextSection.Fixes #812