fix: clear GH_DASH_CONFIG in default-config test#814
Merged
dlvhdr merged 1 commit intodlvhdr:mainfrom Mar 25, 2026
Merged
Conversation
Bug: The TestParser/Should_create_default_config test fails when GH_DASH_CONFIG is set in the environment. Cause: The test set XDG_CONFIG_HOME to an empty temp dir — to isolate it from any actual local config — but didn’t clear GH_DASH_CONFIG. ParseConfig checks GH_DASH_CONFIG — so if it’s set, dash uses the local config file specified in the value, and that local config may specify more PR sections than the 3 the test expects (causing the test to fail). Fix: Clear GH_DASH_CONFIG with t.Setenv (which restores it afterward).
dlvhdr
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: The
TestParser/Should_create_default_configtest fails whenGH_DASH_CONFIGis set in the environment.Cause: The test set
XDG_CONFIG_HOMEto an empty temp dir — to isolate it from any actual local config — but didn’t clearGH_DASH_CONFIG.ParseConfigchecksGH_DASH_CONFIG— so if it’s set, dash uses the local config file specified in the value, and that local config may specify more PR sections than the 3 the test expects (causing the test to fail).Fix: Clear
GH_DASH_CONFIGwitht.Setenv(which restores it afterward).