Fix parsing bugs that caused symbol visibility to be incorrect.#154
Merged
Fix parsing bugs that caused symbol visibility to be incorrect.#154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a few bugs in the specialized parser that is run on code that is imported (i.e. the function bodies and unit test bodies are skipped). Returning
nullfrom these functions caused the parser to go into error recovery mode and skip ahead to the nearest semicolon or closing brace. This causes dsymbol to actually fail to correctly parse well-formed code, leading to problems like dlang-community/DCD#620.In addition to not returning
nullfrom theunittestparser, this change also fixes a problem where some forms of functions with contracts were skipped incorrectly, which also caused them to be missing in autocomplete lists in DCD. There are test cases in the linked DCD draft pull request. dsymbol's unit test coverage is pretty bad and I don't intend to fix that with this pull.Related: