-
Notifications
You must be signed in to change notification settings - Fork 0
Dead code / config cleanup #522
Copy link
Copy link
Open
Labels
cleanupCleanup and removal workCleanup and removal workinfrallmLLM narration integrationLLM narration integrationnarrativesquad:khelbenAssigned to Khelben (CI/CD Dev)Assigned to Khelben (CI/CD Dev)squad:voloAssigned to Volo (Narrative Dev)Assigned to Volo (Narrative Dev)tech-debtCleanup of dead or misleading code/configCleanup of dead or misleading code/config
Milestone
Description
Activity
Metadata
Metadata
Assignees
Labels
cleanupCleanup and removal workCleanup and removal workinfrallmLLM narration integrationLLM narration integrationnarrativesquad:khelbenAssigned to Khelben (CI/CD Dev)Assigned to Khelben (CI/CD Dev)squad:voloAssigned to Volo (Narrative Dev)Assigned to Volo (Narrative Dev)tech-debtCleanup of dead or misleading code/configCleanup of dead or misleading code/config
Summary
Several artifacts are defined but unreachable and should be removed or connected once the real paths land: the orphaned AI Foundry references (if external endpoint is chosen instead), any remaining
AZURE_AI_*traces, and the unreachable narration-type branches. This is the final sweep so the codebase honestly reflects what is wired.Scope / Tasks
infra/modules/ai-foundry.bicepand its commented references (main.bicep:196-205,241) rather than leaving them dangling.AZURE_AI_*removal landed (Issue 4) and no doc still references them.backgroundEnrichatNarrationService.ts:135-159becomes reachable once LLM is configured — verify, don't blindly delete).AmbientSystem.ts:5-6).Acceptance Criteria
LLMNarrationTypeis either reachable at runtime or explicitly documented as intentionally template-only.Dependencies
Milestones A & B (cleanup is only safe once real paths exist); coordinates with Issues 1, 3, 4, 12.
Size
S
Derived from the LLM narration gap analysis (Volo) and decomposition (Elminster).