Skip to content

feat: reorder header CTAs above CLI, restyle CLI snippet#221

Open
MattatDirectus wants to merge 5 commits intomainfrom
bry/cli-header-improvements
Open

feat: reorder header CTAs above CLI, restyle CLI snippet#221
MattatDirectus wants to merge 5 commits intomainfrom
bry/cli-header-improvements

Conversation

@MattatDirectus
Copy link
Copy Markdown
Contributor

What Changed

How to Test

  • Deploy preview:

Checklist

  • pnpm lint passes
  • pnpm typecheck passes
  • Verified changes in deploy preview

@netlify
Copy link
Copy Markdown

netlify bot commented Feb 21, 2026

Deploy Preview for directus-website ready!

Name Link
🔨 Latest commit c125bcd
🔍 Latest deploy log https://app.netlify.com/projects/directus-website/deploys/69bace773bff3b00074c00f9
😎 Deploy Preview https://deploy-preview-221--directus-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@LZylstra LZylstra self-requested a review February 25, 2026 23:12
@LZylstra
Copy link
Copy Markdown
Contributor

LZylstra commented Feb 25, 2026

quick question on the .cli-snippet margin: the new margin-block-start: var(--space-6) on .cli-snippet (line 151 in Header.vue) combines with .separator { margin-block-start: var(--space-6) } so when both render, the separator gets --space-6 of top spacing, then the snippet gets another --space-6 below the separator. was that intentional, or should the snippet be closer to the divider (e.g. just --space-3 from the general sibling rule)?

@LZylstra LZylstra self-requested a review March 3, 2026 22:06
width: 100%;
max-width: 470px;
margin-inline: auto;
margin-block-start: var(--space-6);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you look at the deploy preview and make sure this is what you want. It's just going to add spacing on top of other spacing so I want to be sure that's intentional and looks how you're expecting

Copy link
Copy Markdown
Contributor

@LZylstra LZylstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question about spacing but otherwise this should be good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants