fix(spec): correct response shapes and query params per core review#70
Merged
rijkvanzanten merged 1 commit intofix/update-oas-spec-to-v-11-17-3from Apr 30, 2026
Merged
Conversation
- /auth: data is array of providers, response includes disableDefault - params: rename group -> groupBy and _group -> _groupBy to match sanitizeQuery - /ai/files: return top-level ProviderFileRef, not wrapped in data - registry install/reinstall and utils revert: 200 -> 204 (no payload) - registry list: add meta.filter_count and full extension item schema
Member
Author
|
Used AI to push this one obviously but manually verified these guys. |
rijkvanzanten
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses review findings on #66 by aligning the spec with what Directus core actually returns and parses. Each fix verified against
directus/directus.Summary
/auth:dataisReadProviderOutput[], not a single object. Response also includesdisableDefault(notpublic). AddedsessionOnlyquery param. (api/src/controllers/auth.ts:258,api/src/utils/get-auth-providers.ts:11)groupquery params: renamedgroup→groupByand_group→_groupBy.sanitizeQueryonly parsesgroupBy/_groupBy. (api/src/utils/sanitize-query.ts:48)/ai/files: handler callsres.json(result)whereresultisProviderFileRef. Removed{ data: ... }wrapper, typed full shape (provider,fileId,filename,mimeType,sizeBytes,expiresAt). (api/src/ai/files/controllers/upload.ts:132,packages/ai/src/types.ts:81)res.locals.payload;respondmiddleware emits 204. Changed documented status from 200 to 204. (api/src/middleware/respond.ts:124)meta.filter_countand the full extension item schema (id,name,description,total_downloads,verified,type,last_updated,host_version,sandbox,license,publisher{...}). (packages/extensions-registry/src/modules/list/schemas/registry-list-response.ts)Test plan