perf: typeof will be faster (vs instanceof)#242
Closed
nigrosimone wants to merge 1 commit into
Closed
Conversation
Owner
|
I check if its Regexp, not if its object |
Contributor
Author
|
Pattern only can be "string" or "RegExp" (object) typeof seem faster https://jsperf.app/typeof-function-vs-instanceof/5 |
Owner
|
There's no point in making this function faster, it only gets called once during server init. And even if it was called on every request, this is still pretty much a pointless microoptimization that probably brings like +1 req/sec benefit... No point |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
typeof will return one of the built in types (Object, undefined and the primitives). The instanceof operator should check the prototype chain and see if the right side has been used as a constructor somewhere along. This is naturally more work.