fix: enforce pathLenConstraint regardless of keyUsage extension#1142
Open
eddieran wants to merge 1 commit intodigitalbazaar:mainfrom
Open
fix: enforce pathLenConstraint regardless of keyUsage extension#1142eddieran wants to merge 1 commit intodigitalbazaar:mainfrom
eddieran wants to merge 1 commit intodigitalbazaar:mainfrom
Conversation
The pathLenConstraint check in the certificate chain validation was gated on the keyUsage extension being present. When a CA certificate omitted the keyUsage extension but included basicConstraints with a pathLenConstraint, the constraint was silently skipped, allowing chains that exceeded the maximum permitted depth. Remove the keyUsage guard so pathLenConstraint is enforced whenever basicConstraints is present.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes GHSA-h8mc-2r26-8398. This replaces #1141.
The
pathLenConstraintcheck inverifyCertificateChainwas gated on thekeyUsageextension being present (keyUsageExt !== null). When a CA certificate omitted thekeyUsageextension but includedbasicConstraintswith apathLenConstraint, the constraint was silently skipped — allowing certificate chains that exceeded the maximum permitted intermediate CA depth.Changes
In
lib/x509.js, the condition guarding thepathLenConstraintenforcement now checks forbcExt !== nullinstead ofkeyUsageExt !== null, so the constraint is enforced wheneverbasicConstraintsis present, regardless of whetherkeyUsageis also present.