Merge1.72.0 - #2819
Merged
Merged
Merge1.72.0#2819
Conversation
Related issue: uBlockOrigin/uBOL-home#632 Popup blocking will be enabled by default, and is active when default filtering mode is optimal or complete. Users can wholly disable popup blocking in the dashboard.
Related issue: uBlockOrigin/uAssets#32959
…ic filters There is now no benefit splitting them in two sets of content scripts.
The filter editor is in the "Custom filters" pane in the dashboard, and is available only when "Developer mode" is enabled. The filter editor is also only available in browsers which WebExtensions framework supports the `userScripts` and `offscreen` APIs (so only Chromium-based browsers currently). The filter editor's main purpose is as a tool for filter list authors, it's not meant to be a replacement for importing filter lists due to the maxium number of dynamic DNR rules allowed. This is a first version with a list of TODOs, and some filter syntaxes are currently not supported: - not possible to `badfilter` a filter - cosmetic exception filters do not apply to stock lists - generic cosmetic filters are currently discarded - `popup` filters are discarded - `doc` filters can't trigger the strict-block page
The editor is read-only, thus no need to filter out user rules or rules meant for no-filtering sites.
Under certain conditions, binary search could fail finding a match when following conditions were fulfilled: - There was only one item in the haystack - Multiple needles with first one not being a match This would cause subsequent needles from being correctly identified as a match.
Add support for xpath expressions: if a selector starts with `xpath:`, the selector will instead be used as an xpath expression to find the matching elements. Related discussion: uBlockOrigin/uAssets#33142
If a selector is prefixed with `when-visible:`, the scriptlet will click the matching element only when it becomes visible to the user. Related case: uBlockOrigin/uAssets#33161
This reverts commit 686eefd.
Cosmetic- and scriptlet-based filters from filter-creation sandbox are allowed to be explicitly generic, for example: `*##[filter]`.
Related issue: uBlockOrigin/uBOL-home#708 Unfortunately click-to-load feature is not compatible with DNR syntax. There are no workaround at the moment.
Related issue: uBlockOrigin/uBOL-home#709 Lists build from trusted and non-trusted sources would have their legitimately trusted filters unconditionally discarded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.