refactor: Make util classes final

src/main/java/org/hisp/dhis/BaseDhis2.java

@@ -1160,7 +1160,7 @@
    *   <li>409 Conflict
    * </ul>
    *
-   * @param response the {@link CloseableHttpResponse}.
+   * @param response the {@link ClassicHttpResponse}.
    * @param url the request URL.
    * @throws Dhis2ClientException in the case of error status codes.
    */
@@ -1300,7 +1300,7 @@
   protected Dhis2ClientException newDhis2ClientException(IOException ex) {
     int statusCode = -1;
 
     if (ex instanceof HttpResponseException) {
       statusCode = ((HttpResponseException) ex).getStatusCode();
     }
 

src/main/java/org/hisp/dhis/util/CodecUtils.java

@@ -35,7 +35,7 @@
 import org.apache.commons.codec.digest.DigestUtils;
 
 @NoArgsConstructor(access = AccessLevel.PRIVATE)
-public class CodecUtils {
+public final class CodecUtils {
   /**
    * Generates an MD5 hash of the given input string.
    *

src/main/java/org/hisp/dhis/util/CollectionUtils.java

@@ -47,7 +47,7 @@
 
 /** Utilities for collections. */
 @NoArgsConstructor(access = AccessLevel.PRIVATE)
-public class CollectionUtils {
+public final class CollectionUtils {
   /**
    * Returns an immutable set containing the given items. Accepts null items.
    *

src/main/java/org/hisp/dhis/util/ConfigUtils.java

@@ -40,7 +40,7 @@
 
 /** Utilities for configuration. */
 @NoArgsConstructor(access = AccessLevel.PRIVATE)
-public class ConfigUtils {
+public final class ConfigUtils {
   private static final char VALUE_SEPARATOR = ',';
 
   private static final String VALUE_ENABLED = "on";

src/main/java/org/hisp/dhis/util/DateTimeUtils.java

@@ -47,7 +47,7 @@
 /** Utilities for date and time. */
 @Slf4j
 @NoArgsConstructor(access = AccessLevel.PRIVATE)
-public class DateTimeUtils {
+public final class DateTimeUtils {
   /** Default date format. */
   public static final String DATE_FORMAT = "yyyy-MM-dd";
 

src/main/java/org/hisp/dhis/util/GeoUtils.java

@@ -35,7 +35,7 @@
 
 /** Utilities for geospatial objects. */
 @NoArgsConstructor(access = AccessLevel.PRIVATE)
-public class GeoUtils {
+public final class GeoUtils {
   private static final GeometryFactory GEO_FACTORY = new GeometryFactory();
 
   /**

src/main/java/org/hisp/dhis/util/HttpUtils.java

@@ -44,7 +44,7 @@
 
 /** Utilities for HTTP communication. */
 @NoArgsConstructor(access = AccessLevel.PRIVATE)
-public class HttpUtils {
+public final class HttpUtils {
   /** Pattern for matching a DHIS2 access token as part of a HTTP header value. */
   public static final Pattern PATTERN_ACCESS_TOKEN = Pattern.compile("^ApiToken\\s+(.+)$");
 

src/main/java/org/hisp/dhis/util/IdentifiableObjectUtils.java

@@ -39,7 +39,7 @@
 
 /** Utilities for {@link IdentifiableObject}. */
 @NoArgsConstructor(access = AccessLevel.PRIVATE)
-public class IdentifiableObjectUtils {
+public final class IdentifiableObjectUtils {
   /**
    * Converts the given collection of identifiable objects to a new list of object identifiers.
    *

src/main/java/org/hisp/dhis/util/JacksonUtils.java

@@ -51,7 +51,7 @@
 
 /** Utilities for JSON parsing and serialization. */
 @NoArgsConstructor(access = AccessLevel.PRIVATE)
-public class JacksonUtils {
+public final class JacksonUtils {
   /** Static JSON mapper. */
   private static final JsonMapper JSON_MAPPER;
 
@@ -74,7 +74,7 @@
    *
    * @return a {@link JsonMapper}.
    */
   public static JsonMapper getJsonMapper() {
     return JSON_MAPPER;
   }
 

src/main/java/org/hisp/dhis/util/JacksonXmlUtils.java

@@ -47,7 +47,7 @@
 /** Utilities for XML parsing and serialization. */
 @Slf4j
 @NoArgsConstructor(access = AccessLevel.PRIVATE)
-public class JacksonXmlUtils {
+public final class JacksonXmlUtils {
   /** Default date format. */
   private static final String DATE_FORMAT = "yyyy-MM-dd";
 
@@ -73,7 +73,7 @@
    * @return the XML factory used by the static {@link XmlMapper}.
    */
   public static XmlFactory getXmlFactory() {
     XmlFactory xmlFactory = (XmlFactory) XML_MAPPER.tokenStreamFactory();
     xmlFactory.getXMLInputFactory().setProperty(XMLInputFactory.SUPPORT_DTD, false);
     xmlFactory
         .getXMLInputFactory()

src/main/java/org/hisp/dhis/util/JacksonYamlUtils.java

@@ -37,7 +37,7 @@
 
 @Slf4j
 @NoArgsConstructor(access = AccessLevel.PRIVATE)
-public class JacksonYamlUtils {
+public final class JacksonYamlUtils {
   private static final YAMLMapper YAML_MAPPER;
 
   static {

src/main/java/org/hisp/dhis/util/MetadataItemUtils.java

@@ -32,7 +32,7 @@
 import java.util.Objects;
 import org.hisp.dhis.model.analytics.MetaDataItem;
 
-public class MetadataItemUtils {
+public final class MetadataItemUtils {
   /**
    * Converts the given collection of metaedata items a new list of names.
    *

src/main/java/org/hisp/dhis/util/NumberUtils.java

@@ -38,7 +38,7 @@
 
 /** Utilities for numbers. */
 @NoArgsConstructor(access = AccessLevel.PRIVATE)
-public class NumberUtils {
+public final class NumberUtils {
   /**
    * Scales (rounds) the given double value to the given scale.
    *

src/main/java/org/hisp/dhis/util/ObjectUtils.java

@@ -31,7 +31,7 @@
 import lombok.NoArgsConstructor;
 
 @NoArgsConstructor(access = AccessLevel.PRIVATE)
-public class ObjectUtils {
+public final class ObjectUtils {
   /**
    * Indicates whether the given object is not null.
    *

src/main/java/org/hisp/dhis/util/RegexUtils.java

@@ -34,7 +34,7 @@
 
 /** Utilitis for regular expressions. */
 @NoArgsConstructor(access = AccessLevel.PRIVATE)
-public class RegexUtils {
+public final class RegexUtils {
   /**
    * Returns the first match of the given pattern in the provided value.
    *

src/main/java/org/hisp/dhis/util/TextUtils.java

@@ -31,13 +31,16 @@
 import java.util.regex.Pattern;
 import java.util.stream.Collectors;
 import java.util.stream.Stream;
+import lombok.AccessLevel;
+import lombok.NoArgsConstructor;
 import org.apache.commons.lang3.ObjectUtils;
 import org.apache.commons.lang3.StringUtils;
 import org.apache.commons.lang3.builder.ToStringBuilder;
 import org.apache.commons.lang3.builder.ToStringStyle;
 import org.slf4j.helpers.MessageFormatter;
 
-public class TextUtils {
+@NoArgsConstructor(access = AccessLevel.PRIVATE)
+public final class TextUtils {
   private static final Pattern PATTTERN_VARIABLE = Pattern.compile("^\\$\\{(.*?)\\}$");
 
   private static final String PATTERN_LEAD_TICKS = "^```[a-zA-Z0-9]*\\s*\\n?";