add TH support for nested higher kinded types#2515
Open
ndwarshuis wants to merge 3 commits intodhall-lang:mainfrom
Open
add TH support for nested higher kinded types#2515ndwarshuis wants to merge 3 commits intodhall-lang:mainfrom
ndwarshuis wants to merge 3 commits intodhall-lang:mainfrom
Conversation
Collaborator
|
Sorry for taking so long to get to this I'm a bit reluctant to merge this because (based on my cursory understanding of how this PR works), this is essentially implementing a form of unification (specifically |
Contributor
Author
no problem :)
I'm not sure what you mean by this. Can you please elaborate on "unification" and why it would be difficult to maintain long term? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up to #2506 for a complicated case I forgot to add.
In the case where an imported type uses another higher kinded type, the current algorithm will compare this inner type after its arguments have already been applied, in which case the search will fail.
Example:
Basic idea is to extend the nested type loop so that when matching a dhall type with an already-cached haskell type, it will store the type parameters for the outer haskell type constructor, gather the dhall types corresponding to the type parameters, recursively find the inner constructors for these nested dhall types, and finally apply the results to the outer type constructor.