remove unused buildvars.ComposeBuildDir Var#9704
Open
mlwelles wants to merge 1 commit into
Open
Conversation
ComposeBuildDir was introduced as part of #9691 to support a fork's compose-file generator: tests would route docker-compose invocations through $DGRAPH_COMPOSE_BUILD_DIR to pick up a rewritten compose tree. The fork has since pivoted to a runtime overlay synthesizer that operates entirely in /tmp, leaving ComposeBuildDir with zero call sites — neither in upstream nor in any downstream consumer we know about. The Var is dead surface area. Removes: buildvars/buildvars.go ComposeBuildDir declaration + All slice entry + stale doc-comment reference on Var.defaultValue buildvars/buildvars_test.go ComposeBuildDir case from TestPackageDefaults t/hooks.go $DGRAPH_COMPOSE_BUILD_DIR mention in the ComposeFileArgs docstring; doc tightened to describe the override contract in generic terms
github-actions
Bot
added
area/testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
buildvars.ComposeBuildDir(env varDGRAPH_COMPOSE_BUILD_DIR) landed in #9691 as a hook for forks that ran a compose-file generator: tests would routedocker-composethrough$DGRAPH_COMPOSE_BUILD_DIRto pick up a rewritten compose tree.The Var has zero call sites — upstream code never reads it, and the downstream fork that #9691 was designed for has since pivoted to a runtime overlay synthesizer that operates in
/tmpwithout any env hook. It is dead surface area; remove it.Changes
buildvars/buildvars.go— drop theComposeBuildDir = newVar("DGRAPH_COMPOSE_BUILD_DIR", "")declaration, the entry invar All, and the stalelike ComposeBuildDirreference in theVar.defaultValuedoc comment.buildvars/buildvars_test.go— drop theComposeBuildDirrow fromTestPackageDefaults.t/hooks.go— remove the$DGRAPH_COMPOSE_BUILD_DIRexample from theComposeFileArgsdocstring. Replace with a generic "fork may override to layer additional-f, switch the path, or add--project-directory" description that doesn't presume a particular fork's mechanism.Verification
Backward compatibility
No call sites, no published API stability promise yet (#9691 just merged), and the env var has the empty-string default — so there's no observable behavior change for any consumer that was honoring upstream defaults.