Skip to content

deps: Update yazi and zeno to current - #61

Merged
dfrg merged 1 commit into
dfrg:mainfrom
waywardmonkeys:update-non-fontation-deps
Nov 6, 2024
Merged

deps: Update yazi and zeno to current#61
dfrg merged 1 commit into
dfrg:mainfrom
waywardmonkeys:update-non-fontation-deps

Conversation

@waywardmonkeys

Copy link
Copy Markdown
Collaborator

No description provided.

@waywardmonkeys

Copy link
Copy Markdown
Collaborator Author

I tried to make sure that rendering still worked by using the swash_render example in Parley, but that was broken on main already.

@waywardmonkeys

Copy link
Copy Markdown
Collaborator Author

Doing a workaround in Parley to fix that example and then building with this version of swash still renders.

@waywardmonkeys

Copy link
Copy Markdown
Collaborator Author

@dfrg FYI

@dfrg

dfrg commented Sep 23, 2024

Copy link
Copy Markdown
Owner

I believe updating zeno is a semver breaking change since that crate is publicly re-exported. I’ve held off on doing this because I was trying to think of other breaking changes that might be valuable to include. At the very least, no_std support would be nice.

Since cosmic-text and its users depend on this, I’m trying to be conservative with breaking changes.

@waywardmonkeys

Copy link
Copy Markdown
Collaborator Author

At the very least, no_std support would be nice.

Hint received!

@waywardmonkeys
waywardmonkeys force-pushed the update-non-fontation-deps branch from c23be6b to ba840f2 Compare October 7, 2024 03:01
@waywardmonkeys

Copy link
Copy Markdown
Collaborator Author

Updated / rebased forward after 0.1.19.

@xStrom xStrom left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this landed so that work on #63 can continue. Eventually landing no_std support here is crucial, as it is blocking Parley from getting no_std.

@dfrg
dfrg merged commit bb8c583 into dfrg:main Nov 6, 2024
@dfrg

dfrg commented Nov 6, 2024

Copy link
Copy Markdown
Owner

Thanks all and sorry for the delay. On a related note, would anyone like maintainer status on this repo to help land PRs?

@nicoburns

Copy link
Copy Markdown
Collaborator

Thanks all and sorry for the delay. On a related note, would anyone like maintainer status on this repo to help land PRs?

I would be up for this. I wouldn't necessarily be confident reviewing more invasive changes. But I could definitely help land lint fixes, dependency bumps, CI changes, and such. Perhaps it would be good if a couple of us had permissions (@waywardmonkeys? @xorgy? @xStrom?) then we could merge each other's PRs.

@dfrg

dfrg commented Nov 7, 2024

Copy link
Copy Markdown
Owner

Thanks Nico. Invite sent. I’m also happy to add any of the others you listed but I don’t want to foist responsibility on anyone.

@xorgy

xorgy commented Nov 7, 2024

Copy link
Copy Markdown
Collaborator

@dfrg I would like it, if for no other reason than to be able to label issues/pulls, and maybe go back and make tags and release notes.

@waywardmonkeys

Copy link
Copy Markdown
Collaborator Author

I can join the party too.

@dfrg

dfrg commented Nov 7, 2024

Copy link
Copy Markdown
Owner

Thanks, invites sent.

@xStrom

xStrom commented Nov 7, 2024

Copy link
Copy Markdown
Collaborator

Sure I'll take the invite too. I can do an occasional review.

@dfrg

dfrg commented Nov 7, 2024

Copy link
Copy Markdown
Owner

Thanks Kaur, sent to you as well. Looks like we’re in good shape for reviews now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants