-
Notifications
You must be signed in to change notification settings - Fork 43
feat(frontend): prerender canonical URL for subpages #9455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
a9bb8ab
feat(frontend): prerender canonical URL for subpages
peterpeterparker 0f66e70
🤖 Apply formatting changes
github-actions[bot] 7ae8570
Merge branch 'main' into feat/prerender-subpages
peterpeterparker cb040cb
chore: simplify
peterpeterparker c1c6994
feat: use OISY_IC_DOMAIN
peterpeterparker File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| import { readFileSync, writeFileSync } from 'node:fs'; | ||
| import { dirname, join, relative } from 'node:path'; | ||
| import { ENV, OISY_IC_DOMAIN, findHtmlFiles } from './build.utils.mjs'; | ||
|
|
||
| const OUTPUT_DIR = join(process.cwd(), 'build'); | ||
| const SITE_ROOT_CANONICAL = ENV !== 'production' ? OISY_IC_DOMAIN : 'https://oisy.com'; | ||
|
|
||
| const updateCanonical = (htmlFilePath) => { | ||
| // 1. We determine the route based on the output | ||
| const routePath = dirname(relative(OUTPUT_DIR, htmlFilePath)); | ||
|
|
||
| // 2. Build the effective canonical route | ||
| const canonicalPath = `${SITE_ROOT_CANONICAL}/${routePath}/`; | ||
|
|
||
| // 2. Read content | ||
| let html = readFileSync(htmlFilePath, 'utf-8'); | ||
|
|
||
| // 3. Update canonical | ||
| html = html.replace( | ||
| `<link href="${SITE_ROOT_CANONICAL}" rel="canonical" />`, | ||
| `<link href="${canonicalPath}" rel="canonical" />` | ||
| ); | ||
|
|
||
| // 4. Update og:url to reflect the canonical | ||
| html = html.replace( | ||
| `<meta content="${SITE_ROOT_CANONICAL}" property="og:url" />`, | ||
| `<meta content="${canonicalPath}" property="og:url" />` | ||
| ); | ||
|
|
||
| // 5. Save the content with the updated canonical URL | ||
| writeFileSync(htmlFilePath, html); | ||
| }; | ||
|
|
||
| // Do not replace canonical for root and 404 pages | ||
| const filterSubPages = (htmlFile) => dirname(htmlFile) !== OUTPUT_DIR; | ||
|
|
||
| const htmlFiles = findHtmlFiles().filter(filterSubPages); | ||
| htmlFiles.forEach((htmlFile) => updateCanonical(htmlFile)); | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.