chore: bump snsdemo to release-2026-05-27 and update screenshots#7893
Open
yhabib wants to merge 2 commits into
Open
chore: bump snsdemo to release-2026-05-27 and update screenshots#7893yhabib wants to merge 2 commits into
yhabib wants to merge 2 commits into
Conversation
|
✅ No security or compliance issues detected. Reviewed everything up to c25c154. Security Overview
Detected Code Changes
|
yhabib
force-pushed
the
chore/bump-sns-demo
branch
from
38f3f26 to
c25c154
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR continues from #7892 (the automated "Update snsdemo to release-2026-05-27" PR), which failed CI because four e2e screenshots drifted. Rather than blindly accepting the auto-regenerated images, this PR carries the same snsdemo bump and explicitly commits the updated screenshots, after confirming the diff is expected.
The only visual change across all four screenshots is the Voting Power value (everything else — stake, USD value, layout — is pixel-identical):
neuron-detailsdesktop/mobileneurons-tabledesktop/mobileThis is not snapshot timing drift. It is caused by the NNS "Mission 70" voting-power formula change in the governance canister, which became active in the IC build bundled by snsdemo between
release-2026-05-20andrelease-2026-05-27.Root cause
The snsdemo bump moves a single pin —
DFX_IC_COMMITinbin/versions.bash— which determines every NNS canister WASM snsdemo downloads, including governance:dfinity/iccommitddb51a5(2026-03-12)14382b5(2026-05-25)That range crosses the activation of Mission 70 (
is_mission_70_voting_rewards_enabled()flag), which redefines the dissolve-delay bonus inrs/nns/governance/src/neuron/voting_power.rs:dd_bonus = 1 + t→dd_bonus = 1 + 2·t²(max bonus 2.0x → 3.0x).t = dissolve_delay / max_dissolve_delay, so the same absolute dissolve delay yields a largert. All neurons clamped to 2y on activation.The age bonus is unchanged (
1 + 0.25·age/4y). The new theoretical cap is 3.0 × 1.25 = 3.75x (was 2.5x), which is why a >2.5x multiplier is now possible.The new formula reproduces the e2e numbers exactly
Both test neurons have age bonus = 1.0, so the entire shift comes from the dissolve-delay bonus:
1+t(t=dd/8y)1+2t²(t=dd/2y)The multipliers differ per neuron precisely because the convex
t²term amplifies different dissolve delays differently — a formula change, not a global constant.Changes
SNSDEMO_RELEASEfromrelease-2026-05-20torelease-2026-05-27(same as bot: Update snsdemo to release-2026-05-27 #7892).neuron-detailsandneurons-table(desktop + mobile).Tests
CI should pass with the updated screenshots committed.
Todos