chore(sns_aggregator): rebaseline candid bindings to didc 0.5.4#7889
Open
yhabib wants to merge 2 commits into
Open
chore(sns_aggregator): rebaseline candid bindings to didc 0.5.4#7889yhabib wants to merge 2 commits into
yhabib wants to merge 2 commits into
Conversation
# Motivation The daily aggregator-update workflow has been failing since the didc 0.4.0 → 0.5.4 bump in #7812. The committed bindings were never regenerated under the new didc, so the codegen output drifted from the checked-in files and `ic_sns_ledger.patch` no longer applied cleanly. # Changes - Regenerated all five `ic_sns_*.rs` candid bindings under `didc 0.5.4`. - Re-derived `ic_sns_ledger.patch` against the new baseline (same 3 derive-stripping hunks, updated context). - Updated the `list_topics` call in `upstream.rs` to pass `&ListTopicsRequest` to match the new by-reference canister-method signatures.
didc 0.5.4 emits doc comments propagated from the upstream .did files that trip the pedantic clippy::doc_markdown lint (missing backticks around identifiers, bare URLs). These comments come back on every regeneration, so allow the pedantic lint group in did2rs.header instead of trying to fix the doc comments themselves.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The daily aggregator-update workflow has been failing since the didc 0.4.0 → 0.5.4 bump in #7812. The committed bindings were never regenerated under the new didc, so the codegen output drifted from the checked-in files and
ic_sns_ledger.patchno longer applied cleanly.Changes
ic_sns_*.rscandid bindings underdidc 0.5.4.ic_sns_ledger.patchagainst the new baseline (same 3 derive-stripping hunks, updated context).list_topicscall inupstream.rsto pass&ListTopicsRequestto match the new by-reference canister-method signatures.