chore: remove deprecated ic-cdk imports in ic-icp-test-ledger#10322
Open
gregorydemay wants to merge 1 commit into
Open
chore: remove deprecated ic-cdk imports in ic-icp-test-ledger#10322gregorydemay wants to merge 1 commit into
gregorydemay wants to merge 1 commit into
Conversation
Migrate this test ledger canister off the deprecated `ic_cdk::api::call::{arg_data_raw,
reply_raw}` to `ic_cdk::api::{msg_arg_data, msg_reply}` and drop the file-level
`#![allow(deprecated)]`. The `#![allow(deprecated)]` was introduced later in #8490
than the rest of the DEFI-2304 surface, but has the same root cause (the canister
was templated from another ledger canister that copied the deprecated imports).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the file-level #![allow(deprecated)] from the ic-icp-test-ledger canister by replacing the deprecated ic_cdk::api::call::{arg_data_raw, reply_raw} imports with ic_cdk::api::{msg_arg_data, msg_reply}, aliased to the old names so call sites remain unchanged.
Changes:
- Drop
#![allow(deprecated)]frommain.rs. - Switch to non-deprecated
msg_arg_data/msg_reply, aliased asarg_data_raw/reply_raw.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gregorydemay
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends DEFI-2304 — removing the file-level
#![allow(deprecated)]attribute. Foric-icp-test-ledgerthe attribute was added later by #8490, but it has the same root cause as the rest of the DEFI-2304 surface: the canister was templated from another ledger canister that still used the deprecatedic_cdk::api::call::{arg_data_raw, reply_raw}imports.ic_cdk::api::call::{arg_data_raw, reply_raw}→ic_cdk::api::{msg_arg_data, msg_reply}(imported withasaliases so call sites stay untouched).No behavior change.