chore: DEFI-2304 remove deprecated ic-cdk imports in ic-icp-index#10319
Draft
gregorydemay wants to merge 1 commit into
Draft
chore: DEFI-2304 remove deprecated ic-cdk imports in ic-icp-index#10319gregorydemay wants to merge 1 commit into
gregorydemay wants to merge 1 commit into
Conversation
Migrate the ICP index canister off `ic_cdk::api::caller`, `ic_cdk::api::call::call`, `ic_cdk::api::canister_balance128` and `ic_cdk::api::stable::stable_size` (all deprecated in #6264), and drop the file-level `#![allow(deprecated)]`. The inter-canister calls now use the `ic_cdk::call::Call::unbounded_wait(...).with_arg(...).await?.candid()?` builder (returning `Response::candid` rather than the deprecated `(T,)` tuple shape). The internal `State::last_wait_time` field (tracked separately by DEFI-1144) keeps a narrowly-scoped `#[allow(deprecated)]` on its only construction site. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Migrates ic-icp-index off deprecated ic-cdk 0.18 APIs and removes the file-level #![allow(deprecated)], replacing caller, balance, stable-size, and tuple-style inter-canister call APIs with their modern equivalents.
Changes:
- Replace
caller/canister_balance128/api::stable::stable_sizewithmsg_caller/canister_cycle_balance/stable::stable_size. - Rewrite ledger and archive calls using the
Call::unbounded_wait(...).with_arg(...).await?.candid()?builder. - Narrowly scope the remaining deprecation to
State::default()via#[allow(deprecated)]for thelast_wait_timefield.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends DEFI-2304 — removing the file-level
#![allow(deprecated)]attribute introduced in #6264.This PR handles
ic-icp-index:ic_cdk::api::caller→ic_cdk::api::msg_caller.ic_cdk::api::canister_balance128→ic_cdk::api::canister_cycle_balance.ic_cdk::api::stable::stable_size→ic_cdk::stable::stable_size.ic_cdk::call::Call::unbounded_wait(...).with_arg(...).await?.candid()?builder instead of the deprecated tuple-basedic_cdk::call(canister_id, method, (req,))/(T,)shape.The internal
State::last_wait_timefield is itself separately deprecated (tracked by DEFI-1144); its single construction site keeps a narrowly scoped#[allow(deprecated)]so this PR stays focused on the DEFI-2304 surface.Follows the pattern set by #6755 (
ic-btc-checker), #6761 (ic-ckbtc-minter), #10289, #10290, #10291, #10317 and #10318.