chore: migrate encrypted_notes_app_vetkd to icp CLI and @icp-sdk/vetkeys#1354
Draft
marc0olo wants to merge 11 commits into
Draft
chore: migrate encrypted_notes_app_vetkd to icp CLI and @icp-sdk/vetkeys#1354marc0olo wants to merge 11 commits into
marc0olo wants to merge 11 commits into
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…_ROOT_KEY - Remove rust-toolchain channel pin and profile - Bump ic-cdk to 0.20.1 and add ic-cdk-management-canister 0.1.1 - Update ic_cdk::management_canister imports to ic_cdk_management_canister - Fix ic_root_key -> IC_ROOT_KEY in actor.ts (CanisterEnv type uses uppercase) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Use pwd -P in gen_bindings.sh to resolve paths correctly through symlinks - Change npm ci to npm install --include=dev (no package-lock.json committed) - Add base = "0.11.2" to motoko/mops.toml so mo:base imports resolve Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
svelte-router-spa@6.0.3 declares a peer dep on svelte@^3 but the frontend uses svelte 4. Adding --legacy-peer-deps allows npm to install without strict peer dep enforcement. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
bindgen generates the output file named after the input DID file. The Rust backend DID is encrypted_notes_rust.did, so the generated binding is encrypted_notes_rust.did.ts — not backend.did.ts. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…efix Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Change test_key_1 → key_1 in all icp.yaml: icp-cli 0.2.7 only provisions vetkd:Bls12_381_G2:key_1 (TestThresholdKeys subnet with test_key_1 is not yet supported by icp-cli). The vetkeys library itself uses key_1 in its own icp.yaml files. - Add --yes flag to npx @icp-sdk/bindgen to suppress the install confirmation prompt during local builds - basic_ibe: wrap event listeners in try-catch so errors are caught and shown (not silent unhandled rejections); add console.error() alongside alert() so errors are visible and copyable in DevTools Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Replace manual Actor.createActor(idlFactory, ...) with the generated
createActor(canisterId, { agent }) function and typed Backend wrapper
class from the bindgen-generated declarations. Removes direct imports
of idlFactory, Actor, and ActorSubclass.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
encrypted_notes_rust.did.ts is the IDL-only file (no createActor). The TypeScript wrapper with createActor and Backend is at encrypted_notes_rust.ts — imported without the .did suffix. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Add Folder Structure section explaining rust/, motoko/, frontend/ layout and why backends are in subdirectories (shared frontend via symlinks) - Replace vague "from the X folder" wording with explicit `cd X` commands - Fix `npm run dev` → `npm run dev:rust` / `npm run dev:motoko` (bare `dev` script intentionally errors with a "specify a backend" message) - Add `cd frontend` before all dev commands (package.json is in frontend/, not at the example root) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--yesflag tonpx @icp-sdk/bindgeningen_bindings.shto suppress install promptrust-vetkeys-{example}-{language}-{platform}to{language}-{example}-{platform}for clarityNotes
Test plan
🤖 Generated with Claude Code