chore(vetkeys): migrate basic_bls_signing to icp-cli and @icp-sdk/vetkeys#1352
Draft
marc0olo wants to merge 6 commits into
Draft
chore(vetkeys): migrate basic_bls_signing to icp-cli and @icp-sdk/vetkeys#1352marc0olo wants to merge 6 commits into
marc0olo wants to merge 6 commits into
Conversation
…keys - Replace dfx.json with icp.yaml (Rust and Motoko backends) - Use @icp-sdk/vetkeys@0.5.0-beta.0 instead of @dfinity/vetkeys - Use @icp-sdk/auth@7.1.0 and @icp-sdk/core@5.4.0 - Update Motoko ic-vetkeys to 0.5.0, Rust ic-vetkeys to 0.7.0 - Add moc 1.5.1 toolchain to mops.toml - Replace dfx generate with @icp-sdk/bindgen in gen_bindings.sh - Add CI workflow for both Rust and Motoko backends - Drop icp.ninja support (dfx.json removed) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Drop channel = "1.88.0" and profile = "default" from rust-toolchain.toml; use stable Rust from provision script to avoid the cargo component error introduced in 1.88.0 where cargo is no longer a standalone component - Remove cargo install candid-extractor from CI; the guard in gen_bindings.sh skips make extract-candid when the binary is absent, using the committed .did Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The icp CLI's @dfinity/asset-canister recipe symlinks frontend/ into the backend subdirectory during build. Bash's `cd ../..` operates on logical paths, so it lands back in the backend dir instead of the example root, causing bindgen to look for `<backend>/rust/backend/backend.did`. Use `pwd -P` to resolve the script's physical location and derive absolute paths for the example root, frontend dir, and the .did file. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Replace AuthClient.create() with new AuthClient({ identityProvider })
- Replace client.login({onSuccess,onError}) with await client.signIn()
- Replace client.logout() with client.signOut()
- Await authClient.getIdentity() (now async in v7)
- isAuthenticated() is now synchronous (no await)
- Fix ic_root_key → IC_ROOT_KEY (CanisterEnv type uses uppercase)
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
ic-vetkeys 0.7.0 requires ic-cdk ^0.20.1 which uses ic-cdk-executor ^2.0.0. The previously pinned ic-cdk 0.18.3 requires ic-cdk-executor ^1.0.0. Since ic-cdk-executor uses `links`, only one version can exist in the graph. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
In ic-cdk 0.20, the management_canister module was extracted into the separate ic-cdk-management-canister crate. Update imports from ic_cdk::management_canister to ic_cdk_management_canister. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates the
basic_bls_signingvetkeys example as part of #1343:dfx.jsonwithicp.yamlfor both Rust and Motoko backends@dfinity/vetkeys@0.3.0with@icp-sdk/vetkeys@0.5.0-beta.0@dfinity/auth-client/@dfinity/principal/@dfinity/agentwith@icp-sdk/auth@7.1.0/@icp-sdk/core@5.4.0ic-vetkeysto0.7.0ic-vetkeysto0.5.0, updatescoreto2.4.0, adds[toolchain] moc = "1.5.1"dfx generatewith@icp-sdk/bindgeningen_bindings.shvite.config.tsto useicpCLI for dev server configwindow.globalpolyfill, updates all actor creation to useHttpAgent.create()+Actor.createActor()rust-vetkeys-basic-bls-signing-example.yml) for both Rust and Motoko on Darwin and Linuxdfx.json= not deployable on icp.ninja), comments out icp.ninja badges in READMETest plan
npm installresolves without errors infrontend/icp network start -d && icp deploysucceeds fromrust/andmotoko/dirs@dfinity/vetkeysordfxreferences in the example🤖 Generated with Claude Code