Skip to content

feat(navigation-menu): update v-model bindings to use modelValue for consistency #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elonehoo merged 1 commit into from
Jul 3, 2026
Merged

feat(navigation-menu): update v-model bindings to use modelValue for consistency #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 18 additions & 11 deletions packages/vue/src/components/navigation-menu/composables/use-navigation-menu.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,17 +21,24 @@ export function useNavigationMenu(props: UseNavigationMenuProps = {}, emit?: Emi
const env = useEnvironmentContext()
const locale = useLocaleContext(DEFAULT_LOCALE)

const context = computed(() => ({
id,
dir: locale.value.dir,
value: props.modelValue ?? props.defaultValue ?? null,
getRootNode: env?.value.getRootNode,
onValueChange: (details: navigationMenu.ValueChangeDetails) => {
emit?.('valueChange', details)
emit?.('update:modelValue', details.value)
},
...cleanProps(props),
}))
const context = computed(() => {
const controlled = props.modelValue !== undefined
const value = controlled ? props.modelValue : props.defaultValue

return {
...cleanProps(props),
'id': props.id ?? id,
'dir': locale.value.dir,
'value': value ?? null,
'defaultValue': controlled ? props.modelValue ?? undefined : props.defaultValue,
'value.controlled': controlled,
'getRootNode': env?.value.getRootNode,
'onValueChange': (details: navigationMenu.ValueChangeDetails) => {
emit?.('valueChange', details)
emit?.('update:modelValue', details.value)
},
}
})

const [state, send, machine] = useMachine(navigationMenu.machine(context.value), { context })
const api = computed(() => navigationMenu.connect(state.value, send, normalizeProps))
Expand Down
12 changes: 9 additions & 3 deletions packages/vue/src/components/navigation-menu/test/navigation-menu.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,12 +50,18 @@ describe('[navigation-menu] component', () => {
})
})

it('should support controlled value', async () => {
render(Basic, { props: { value: 'getting-started', openDelay: 0, closeDelay: 0 } })
it('should support controlled modelValue', async () => {
render(Basic, { props: { modelValue: 'components', openDelay: 0, closeDelay: 0 } })

await vi.waitFor(async () => {
await expect.element(page.getByText('How to install dependencies and structure your app.')).toBeVisible()
await expect.element(page.getByText('A modal dialog that interrupts the user with important content.')).toBeVisible()
})

const trigger = page.getByRole('button', { name: 'Getting started' })
await userEvent.click(trigger)

await expect.element(page.getByText('A modal dialog that interrupts the user with important content.')).toBeVisible()
await expect.element(page.getByText('How to install dependencies and structure your app.')).not.toBeVisible()
})

it('should support default value', async () => {
Expand Down
Loading