Error fixes in entity classes.

[skellamp]

TODO

• update to boolean after merge of Fix boolean fields represented as integers in database schema vufind-org/vufind#2689 in UserList and Search.

[demiankatz]

Thanks, @skellamp, this is an excellent start, and I appreciate the significant amount of work that you obviously put into this.

I've left a few comments -- there are some very small typos and minor suggestions about rephrasing descriptions. There are also a couple of areas where I had questions about Doctrine best practices. I also noticed some inconsistencies that, while probably not wrong, we might want to standardize to make sure we're treating the same situations in the same ways across all of the entities.

I hope this is helpful! I'm happy to discuss further as needed.

[demiankatz]

Might want to add TODO: update to boolean after merge of #2689 so we don't lose track of finishing that cleanup after the PR is completed.

[demiankatz]

Also, please don't worry about the failing dependency review -- I think this has to do with permissions on the demiankatz repository vs. permissions on the vufind-org repository. The important CI checks are passing now, which is a great step forward. I don't expect we'll see any problems once we merge this into the main Doctrine PR.

[demiankatz]

I have moved outstanding work from here into TODO checkboxes on vufind-org#2689, and the build is passing here, so I am merging now. Thanks again for your help cleaning all this up!