Extend styx metrics + grafana dashboard & implement additional client load patterns#36
Open
Erhan1706 wants to merge 3 commits intodelftdata:mainfrom
Open
Extend styx metrics + grafana dashboard & implement additional client load patterns#36Erhan1706 wants to merge 3 commits intodelftdata:mainfrom
Erhan1706 wants to merge 3 commits intodelftdata:mainfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #36 +/- ##
==========================================
- Coverage 88.14% 84.38% -3.77%
==========================================
Files 45 48 +3
Lines 2616 2754 +138
==========================================
+ Hits 2306 2324 +18
- Misses 310 430 +120
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Member
|
Hey @Erhan1706 ! Thanks a lot for the contribution! I would need some time to review this. In the meantime, could you check why the e2e tests are failing? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In my previous meeting Oto and Asterios mentioned that some bachelor students will start their thesis working on styx, and the tooling I developed in my fork might be useful for them. This PR contributes a portion of those changes, focused on metrics and load generation.
Summary
Changes:
Usage: ./scripts/run_experiment.sh dhr 1000 100000 2 0 1 200 results 10 1000 cosine
Can also be left blank (for backwards compatibility) and it will use the constant input generator.
Metric overhead
To figure out the overhead of the extra metrics, I tried to do a mini benchmark by running the same workloads for a version with the extra metrics and a version without.
For example these are the latency results for 4 runs of ycsbt with 2 workers, input rate=3000, n_keys=100000, for 4 minutes:
[With metrics]
run1.csv (16 samples, mean=8.00)
run2.csv (16 samples, mean=7.92)
run3.csv (15 samples, mean=7.29)
run4.csv (15 samples, mean=8.38)
[Without metrics]
run1.csv (16 samples, mean=4.14)
run2.csv (16 samples, mean=3.68)
run3.csv (16 samples, mean=3.29)
run4.csv (15 samples, mean=4.46)
The metrics are quite extensive, some of them I am currently not using (like the per-phase metrics) for my autoscaling policy in my fork, but I still decided to include them for completeness. If the overhead is too much, I can remove some of them to try to reduce the costs a bit.