Repository navigation
Stop the comms logger exiting on all_gather_object and monitored_barrier - #8896
Draft
vineethsaivs wants to merge 1 commit into
Draft
vineethsaivs wants to merge 1 commit into
vineethsaivs wants to merge 1 commit into
Conversation
calc_bw_log had no branch for these two ops, although both are wrapped in timed_op. With comms profiling on, the first call printed 'wrong comm_op specified' and ran exit(0), ending the process with status 0. Count them like all_gather and barrier. Signed-off-by: Vineeth Sai <vineethsai4444@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With comms profiling on (
prof_all,proforprof_ops), the firstdist.all_gather_object(...)ordist.monitored_barrier()printswrong comm_op specifiedand ends the process with exit status 0, so a run stops silently.Cause: both ops are wrapped in
@timed_op, butcalc_bw_loghas no branch for them and its fallback callsexit(0).Fix: count
all_gather_objectwithall_gatherandmonitored_barrierwith the barrier ops. Their message size is 0, so bandwidth reads 0, as forbroadcast_object_list.Test:
pytest tests/unit/comm/test_comms_logger.pyon CPU (gloo, macOS, no GPU): the newsupports_every_timed_opcase fails before (2 failed,SystemExit: 0), whole file passes after (54 passed). A gloo run withprof_allreproduced the exit before and logs both ops after.Related open PRs #8695, #8795 and #8798 touch nearby logger code; none cover these two ops.
AI assistance was used to prepare this change; the diff and test results were reviewed before submitting.