Repository navigation
Detect NEON when py-cpuinfo reports no CPU flags - #8765
Draft
vineethsaivs wants to merge 1 commit into
Draft
vineethsaivs wants to merge 1 commit into
vineethsaivs wants to merge 1 commit into
Conversation
On Apple Silicon py-cpuinfo returns no 'flags' key, so simd_width() raised KeyError on the SVE check and CPU ops such as cpu_adam could not build. Read the flags with a default so these CPUs fall through to the NEON path. Signed-off-by: Vineeth Sai <vineethsai4444@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Apple Silicon, building CPU ops such as
cpu_adamfails withKeyError: 'flags'before the compiler runs.simd_width()indexescpu_info['flags'], but py-cpuinfo returns noflagskey on M-series Macs (it gives only arch, brand, bits and count). The SVE check added in #8365 sits ahead of the NEON branch from #8453, so these CPUs never reach NEON.Fix: read the flags once with
cpu_info.get('flags', []). Apple Silicon now gets-D__NEON__; CPUs that report flags are unchanged.Test: new parametrized test in
tests/unit/ops/test_op_builder.pycovers a cpu_info without flags (fails on master with KeyError, passes here) and one withsve. On an M2 Pro with real py-cpuinfo,simd_width()goes from KeyError to-D__NEON__. The test file: 18 passed, 1 skipped; yapf and flake8 clean.