Repository navigation
ZeRO-1/2: configure quantized weight all-gather groups - #8513
Closed
adenzhou1350 wants to merge 3 commits into
Closed
adenzhou1350 wants to merge 3 commits into
adenzhou1350 wants to merge 3 commits into
Conversation
Signed-off-by: Xucheng Zhou <aden1350@outlook.com>
Signed-off-by: Xucheng Zhou <aden1350@outlook.com>
Signed-off-by: Xucheng Zhou <aden1350@outlook.com>
adenzhou1350
force-pushed
the
codex/c26-configurable-quantized-group-pr
branch
from
September 14, 2026 12:13
6985467 to
80e452a
Compare
Contributor
Author
|
Closing this stacked follow-up to keep the upstream queue focused. Its prerequisite is still undergoing exact-head requalification, and this configurable-group layer does not yet have independent current-head distributed evidence. The branch and local evidence remain available if a maintainer later requests this surface after the prerequisite is qualified. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependency
This is a stacked follow-up to #8511, which is currently a draft pending exact-head multi-GPU requalification. Until that PR merges, GitHub also shows its prerequisite commits; the change specific to this PR is the final
ZeRO-1/2: configure quantized weight group sizecommit.Summary
zero_quantized_weights_group_sizefor ZeRO-1/2;This exposes the accuracy/scale-traffic tradeoff without changing defaults. A prior qualification workload used group size 8192, but this PR does not propose 8192 as a shared default.
Current status (
80e452a)This PR remains a draft until both its prerequisite and the configurable group path have device-backed distributed evidence on their current heads.
Historical pre-fix evidence
The following results came from the earlier stack, before the current prerequisite fix/rebase. They screen the idea but are not current-head qualification:
1.03633x,1.03936x,1.03794x,1.03614x1.03713x; bootstrap 95% interval[1.03614, 1.03936]The comparison also used a 100M reduce bucket. That was a workload setting, not a new default or source constant.
Scope and risks
Larger groups trade scale traffic for precision and must be validated per workload. Existing evidence does not establish behavior for ZeRO-1, FP16, offload, MoE, H100/B300, NVLink/RDMA, other models, or long-horizon convergence.