Release workflow update - #12241
Open
anakin87 wants to merge 4 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
Coverage report
This PR does not seem to contain any modification to coverable code. |
Move GH_TOKEN from the job-level env to just the four steps that call gh, so the checkout and final failure-check steps in this job no longer have the bot token in their environment. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
julian-risch
approved these changes
Aug 4, 2026
julian-risch
left a comment
julian-risch
left a comment
Member
There was a problem hiding this comment.
Looks good to me! Thanks for working on this. The change that I applied directly is about scoping the token only to the steps that need it instead of the job, following best practices. Only other action in the job right now is actions/checkout but it's still better to scope it only to the steps that need it. Otherwise there is the risk that we might add another step to the job in future and increase exposure more and more. It's also better to follow this standard consistently throughout our repos.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
How did you test it?
Several local tests. Haven't tested the new release workflow with an actual release, so something might still fail next time; we'll fix it.
Notes for the reviewer
Once this is done, I'll see which changes to port into the v2.31.x branch (2.31 release line).
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:and added!in case the PR includes breaking changes.