Try to detect 802.3ad LACP bonding slaves and multiply by slave count#618
Open
michaelchen1996 wants to merge 1 commit into
Open
Try to detect 802.3ad LACP bonding slaves and multiply by slave count#618michaelchen1996 wants to merge 1 commit into
michaelchen1996 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We found the get_rdma_gbs() function in #605 deep_ep/utils/envs.py:246 uses ibstat to detect the RDMA NIC bandwidth, which is then used to calculate the number of SMs.
However, in LACP bonding environments, ibstat reports only half of the actual bandwidth, leading to incorrect SM calculation.
This change is for detecting 802.3ad LACP bonding slaves and multiplying rdma rate by slave count.
refer: #614