[cms] Fix the update of empty user owned proposals and supervisors#1267
Open
thi4go wants to merge 6 commits into
Open
[cms] Fix the update of empty user owned proposals and supervisors#1267thi4go wants to merge 6 commits into
thi4go wants to merge 6 commits into
Conversation
Member
|
So change look ok I think, but we need to make sure now that cmswww or gui sends the value of the supervisorid or proposals owned field, since if they are empty on the request they will be cleared in the db |
Member
Author
|
Hey mate @alexlyp good point. Updated Will make sure that |
Member
Author
|
For the record, as per this discussion on riot, it was decided to create a custom action provider for the cms manage user route. Now, more complex fields to deal with like supervisor ids and proposals owned, can use them to be handled with more simplicity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This diff solves a misbehaviour where we couldn't set the owned proposals and supervisors id fields back to empty. Now we check the updated fields agains't the previous records to see if there was any changes, and if so, continue with the update.