Skip to content

bug: Update to use logging that doesn't print possibly private inform… #4034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alexlyp wants to merge 1 commit into
base: master
Choose a base branch
from
Open

bug: Update to use logging that doesn't print possibly private inform… #4034

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions app/wallet/loader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export const getLoader = withLogNoData(
"Get Loader"
);

export const startRpc = log(
export const startRpc = withLogNoData(
(loader, daemonhost, rpcport, rpcuser, rpcpass, cert) =>
new Promise((resolve, reject) => {
const request = new StartConsensusRpcRequest();
Expand All @@ -55,7 +55,7 @@ export const startRpc = log(
logOptionNoArgs()
);

export const createWallet = log(
export const createWallet = withLogNoData(
async (loader, pubPass, privPass, seed) => {
// Show seed confirmation dialog via BrowserView. If the passed hex seed has
// exactly 64 chars (i.e. 256 bit seed) convert it to a standard 33-word
Expand Down Expand Up @@ -93,7 +93,7 @@ export const createWatchingOnlyWallet = log(
logOptionNoArgs()
);

export const openWallet = log(
export const openWallet = withLogNoData(
(loader, pubPass) =>
new Promise((resolve, reject) => {
const request = new OpenWalletRequest();
Expand All @@ -116,7 +116,7 @@ export const closeWallet = log(
"Close Wallet"
);

export const discoverAddresses = log(
export const discoverAddresses = withLogNoData(
(loader, shouldDiscoverAccounts, privPass, startingBlockHash) =>
new Promise((resolve, reject) => {
const request = new DiscoverAddressesRequest();
Expand Down Expand Up @@ -160,7 +160,7 @@ export const fetchHeaders = log(
"Fetch Headers"
);

export const spvSync = log(
export const spvSync = withLogNoData(
async (loader, spvConnect, discoverAccts, setPrivPass) => {
const request = new SpvSyncRequest();
for (let i = 0; spvConnect && i < spvConnect.length; i++) {
Expand All @@ -176,7 +176,7 @@ export const spvSync = log(
"Start SPV Sync"
);

export const rpcSync = log(
export const rpcSync = withLogNoData(
async (loader, rpcCreds, discoverAccts, setPrivPass) => {
const { rpc_user, rpc_cert, rpc_pass, rpc_host, rpc_port } = rpcCreds;
const request = new RpcSyncRequest();
Expand Down
Loading