fix(ref-imp): allow setting controller property#1174
fix(ref-imp): allow setting controller property#1174clehner wants to merge 1 commit intodecentralized-identity:masterfrom
Conversation
Use the controller property of the public key entry, if present, as the verification method controller property.
clehner
requested review from
OR13,
csuwildcat,
thehenrytsai,
tplooker,
troyronda and
xinaxu
as code owners
|
@thehenrytsai this would be a breaking consensus change for existing implementations. Can we accept this and plan an ION release separately? |
| const publicKeyIdSet: Set<string> = new Set(); | ||
| for (const publicKey of publicKeys) { | ||
| const allowedProperties = new Set(['id', 'type', 'purposes', 'publicKeyJwk']); | ||
| const allowedProperties = new Set(['id', 'type', 'purposes', 'publicKeyJwk', 'controller']); |
There was a problem hiding this comment.
The linked spec says the controller must be a DID and optionally not exceed some maximum length. Need to add such checks and tests accordingly.
thehenrytsai
left a comment
thehenrytsai
left a comment
There was a problem hiding this comment.
Recommend (also responding to @csuwildcat) to just copy the changes to latest folder to 1.0 also so that we don't need to snapshot an additional version folder just for this change. I'd be shocked if there were any operations that were discarded because of inclusion of a controller property.
|
hello, any update for this change? does sidetree plan to support controller property |
|
Was waiting for the contributor to update the PR to merge this. I'd love to know more about the scenarios/use cases of this property from anyone who's an advocate for the feature, I can probably make the requested changes myself and merge it in! |
5 participants
Allow setting the controller property of a public key entry (verification method object), as described here: https://identity.foundation/sidetree/spec/v1.0.0/#add-public-keys