Fix BitcoinClient LoadWallet Errors#48
Fix BitcoinClient LoadWallet Errors#48sangaman wants to merge 2 commits intodecentralized-identity:mainfrom
Conversation
sangaman
requested review from
OR13,
csuwildcat,
thehenrytsai,
tplooker,
troyronda and
xinaxu
as code owners
thehenrytsai
left a comment
thehenrytsai
left a comment
There was a problem hiding this comment.
Hey @sangaman, thanks for submitting the PR. The PR looks good but just for sanity: Were you able to run the ION node on other versions with no issues? My node is running on v0.21.0 which is newer than v0.20.1 but it doesn't seem to have this issue.
This second boolean parameter causes an error on Bitcoin Core v0.20 and older versions. This parameter, in newer versions of bitcoin, is supposed to cause a wallet to be automatically loaded, but this is unnecessary as sidetree makes a loadwallet call anyway.
Hi @thehenrytsai, thanks for your attention. I think I was actually mistaken earlier that v25.0 doesn't support this second The reason I'm using v0.20.1 is because of this issue decentralized-identity/ion#275 - and it seems the PR resolving it (decentralized-identity/sidetree#1192) is still not merged. I fixed a couple of tests and reworded the commit message to reflect that this fix only address v0.20 versions of bitcoin core and below. |
2 participants
Don't pass second param to loadWallet
This second boolean parameter causes an error on error on Bitcoin Core v0.20.1 and v25.0. It is not a documented parameter in v25 and newer versions of Bitcoin Core.
This parameter, in some versions of bitcoin, was supposed to cause a wallet to be automatically loaded, but this is unnecessary as sidetree makes a loadwallet call anyway.
Catch duplicate loadWallet error