Skip to content

chore: expose requestid for cross tests #8862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cyaiox wants to merge 6 commits into
base: dev
Choose a base branch
from
+20 −1
Open

chore: expose requestid for cross tests #8862

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ab807fa
chore(browser): write opened URL to auth-url.txt under #if ALTTESTER
cyaiox May 21, 2026
cb0c4ae
chore(browser): suppress Application.OpenURL in #if ALTTESTER builds
cyaiox May 21, 2026
1a78c82
chore(browser): cross-platform path + ReportHub for ALTTESTER auth-ur…
cyaiox May 22, 2026
eb79cc6
chore(browser): collapse two-line comment to single line per review
cyaiox May 22, 2026
e498476
Merge branch 'dev' of github.com:decentraland/unity-explorer into cho…
cyaiox May 22, 2026
ec397f0
Merge branch 'dev' into chore/expose-requestid-for-cross-tests
cyaiox Jun 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion Explorer/Assets/DCL/NetworkDefinitions/Browser/UnityAppWebBrowser.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
using DCL.Multiplayer.Connections.DecentralandUrls;
using System;
using UnityEngine;
#if ALTTESTER
using DCL.Diagnostics;
using System.IO;
#endif

namespace DCL.Browser
{
Expand All @@ -15,7 +19,23 @@ public UnityAppWebBrowser(IDecentralandUrlsSource decentralandUrlsSource)

public void OpenUrl(string url)
{
Application.OpenURL(Uri.EscapeUriString(url));
var escaped = Uri.EscapeUriString(url);

#if ALTTESTER
// ALTTESTER builds redirect the auth URL to disk and suppress the system browser
// so cross-stack Playwright tests can drive their own browser to the same target.
try
Copy link
Copy Markdown
Contributor

@claude claude Bot May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per CLAUDE.md: "Never write multi-line comment blocks — one short line max." This 2-line comment should be compressed to one line.

Suggested change
// so cross-stack Playwright tests can drive their own browser to the same target.
try
// ALTTESTER builds write auth URL to disk and suppress the system browser so Playwright tests can drive their own browser to it.

{
var path = Path.Combine(Application.persistentDataPath, "auth-url.txt");
File.WriteAllText(path, escaped);
}
catch (Exception e)
{
ReportHub.LogException(e, ReportCategory.AUTHENTICATION);
}
#else
Application.OpenURL(escaped);
#endif
}

public void OpenUrl(DecentralandUrl url)
Expand Down
Loading