Skip to content

chore: report exception of command on failure #8852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NickKhalow wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

chore: report exception of command on failure #8852

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion Explorer/Assets/DCL/Chat/MessageBus/CommandsHandleChatMessageBus.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
using System.Linq;
using System.Threading;
using Utility;
using DCL.Diagnostics;

namespace DCL.Chat.MessageBus
{
Expand Down Expand Up @@ -69,7 +70,11 @@ private async UniTaskVoid HandleChatCommandAsync(ChatChannel.ChannelId channelId
string response = await command.ExecuteCommandAsync(parameters, commandCts.Token);
SendFromSystem(channelId, channelType, response);
}
catch (Exception) { SendFromSystem(channelId, channelType, "🔴 Error running command."); }
catch (Exception e)
{
SendFromSystem(channelId, channelType, "🔴 Error running command.");
ReportHub.LogError(ReportCategory.UNSPECIFIED, $"Error running command: {e}");
Copy link
Copy Markdown
Contributor

@claude claude Bot May 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per CLAUDE.md §9, exceptions should be reported via ReportHub.LogException (not LogError with a string). LogException preserves structured exception data in the diagnostics system.

Also, OperationCanceledException should not be logged as an error — it's expected when commandCts.SafeRestart() cancels an in-flight command.

Suggested change
ReportHub.LogError(ReportCategory.UNSPECIFIED, $"Error running command: {e}");
ReportHub.LogException(e, new ReportData(ReportCategory.UNSPECIFIED));

And add a guard to the catch clause:

catch (Exception e) when (e is not OperationCanceledException)

}

return;
}
Expand Down
Loading