fix: deep link to world redirects to Genesis after account change#8848
Draft
Maurizio-dcl wants to merge 2 commits into
Draft
fix: deep link to world redirects to Genesis after account change#8848Maurizio-dcl wants to merge 2 commits into
Maurizio-dcl wants to merge 2 commits into
Conversation
- Moved world access check from bootstrap to post-auth in the loading flow, so it runs against the identity the user actually picked (rather than the cached one). Remove the now-dead IsUserAuthorisedToAccessWorldAsync from IRealmController.
Contributor
|
Windows and Mac build successful in Unity Cloud! You can find a link to the downloadable artifact below. |
Collaborator
|
PR #8848, run #26229701217 Builds: Windows change, Windows baseline, macOS change, macOS baseline Framework 13 i7
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fix #8802
What does this PR change?
This PR moves the world access check from bootstrap to post-auth in the loading flow, this fixes a bug where changing accounts would lead to an inconsistent state regarding world permission since they were checked only against the initial identity.
Moved world access check from bootstrap to post-auth in the loading flow, so it runs against the identity the user actually picked (rather than the cached one).
Removed the now-dead IsUserAuthorisedToAccessWorldAsync from IRealmController.
Test Instructions
Prerequisites
--realm=italy2026.dcl.eth --position 20,20args.italy2026.dcl.eth, one without (can be tested with any world to which at least one of your accounts have access).Test Steps
Primary repro (cached account has NO access, switch to one that does):
Reverse case (cached account HAS access, switch to one that doesn't):
Direct entry regression:
Public world:
Normal launch (no deep link):
Quality Checklist