Skip to content

chore: anchor Claude verdict marker filter to line-start#8835

Open
aixaCode wants to merge 6 commits into
devfrom
chore/test-claude-review-workflow
Open

chore: anchor Claude verdict marker filter to line-start#8835
aixaCode wants to merge 6 commits into
devfrom
chore/test-claude-review-workflow

Conversation

@aixaCode
Copy link
Copy Markdown
Collaborator

@aixaCode aixaCode commented May 20, 2026

Summary

Follow-up to #8833. The dedupe filter matched REVIEW_RESULT: / DEPENDENCY_REVIEW: anywhere in the body, so when one Claude review's verdict text discusses the other's marker (e.g. on workflow-meta PRs) the wrong comment got minimized.

Tighten the filter to require an actual verdict value (PASS / FAIL for code review; PASS / BLOCK / NEEDS_ATTENTION for dependency security) at the start of a line. Mentions inside prose or inline code no longer match.

Also includes a tiny doc wording tweak in docs/master-of-bots.md from the earlier smoke test that surfaced this bug.

Test plan

  • Auto-review verdict on this PR stays visible; security review verdict (if it fires) stays visible too
  • On a follow-up push, older verdicts collapse as "outdated" — but only their own kind

aixaCode added 4 commits May 20, 2026 15:01
Workflow-level concurrency joins the group before job if: filters run,
so claude[bot]'s own progress comments triggered new issue_comment runs
that cancelled in-flight reviews. Move concurrency to the auto-review
and review jobs so skipped jobs never enter the group.
@aixaCode aixaCode requested review from a team as code owners May 20, 2026 15:44
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 20, 2026

badge

Build skipped — no changes detected under Explorer/.

@claude

This comment has been minimized.

@claude

This comment has been minimized.

@github-actions
Copy link
Copy Markdown
Contributor

🔒 Claude reviewed this PR — sensitive paths modified (.github/prompts, .github/workflows, or CODEOWNERS). Claude will not auto-approve these PRs — human DEV review is required. No QA needed (Claude reported QA_REQUIRED: NO).

@github-actions github-actions Bot added the no QA needed Used to tag pull requests that does not require QA validation label May 20, 2026
@claude
Copy link
Copy Markdown
Contributor

claude Bot commented May 20, 2026

Claude finished @aixaCode's task in 23s —— View job


Review

  • Read CLAUDE.md and docs/README.md
  • Reviewed PR diff
  • Posted verdict

Root-cause check

This PR fixes a minor grammar/phrasing issue in documentation (docs/master-of-bots.md). The change addresses the actual wording directly — not a symptom, not a workaround.

Diff summary

docs/master-of-bots.md line 3: "big amounts … of users""large numbers … of users". Single-line documentation correction; no code touched.

Blocking issues

None.

Non-blocking warnings

None.


REVIEW_RESULT: PASS ✅
COMPLEXITY: SIMPLE
COMPLEXITY_REASON: Diff touches only a documentation file with a single-word wording fix.
QA_REQUIRED: NO

github-actions[bot]
github-actions Bot previously approved these changes May 20, 2026
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved by Claude — simple fix/chore with no blocking issues. No QA needed (non-runtime changes only).

Substring match on REVIEW_RESULT: / DEPENDENCY_REVIEW: also catches
review bodies that merely discuss the marker text, so cross-workflow
verdicts were getting minimized as collateral. Require a real verdict
value (PASS/FAIL/BLOCK/NEEDS_ATTENTION) on its own line.
@aixaCode aixaCode changed the title chore: polish master-of-bots docs wording chore: anchor Claude verdict marker filter to line-start May 20, 2026
@github-actions github-actions Bot dismissed their stale review May 20, 2026 16:36

Dismissed: latest Claude review no longer auto-approves this PR.

@github-actions github-actions Bot removed claude-approved no QA needed Used to tag pull requests that does not require QA validation labels May 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant