chore: consolidate DCL.PrivateWorlds into DCL.RealmNavigation#8800
Open
biotech77 wants to merge 3 commits into
Open
chore: consolidate DCL.PrivateWorlds into DCL.RealmNavigation#8800biotech77 wants to merge 3 commits into
biotech77 wants to merge 3 commits into
Conversation
Contributor
|
Windows and Mac build successful in Unity Cloud! You can find a link to the downloadable artifact below. |
mikhail-dcl
approved these changes
May 18, 2026
Contributor
PR Review
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Resolves #7551
What does this PR change?
Removes
DCL.PrivateWorlds.asmdefand folds its 8 files intoDCL.RealmNavigation/PrivateWorlds/. RemovesCommunityMembershipCheckerAdapter, replaced byCommunitiesDataProviderimplementingICommunityMembershipCheckerdirectly.The adapter existed only to avoid an asmdef cycle (Social → PrivateWorlds, but PrivateWorlds needed
CommunitiesDataProviderfrom Social).Test Instructions
Steps (standard run):
metaforge explorer run XXXX # ← replace with this PR numberExpected result:
Steps (fresh account):
metaforge account create --clear metaforge explorer run XXXX # ← replace with this PR numberExpected result:
Automation (if applicable):
metaforge explorer test XXXXTest Steps
Retest and verify all tests work from original PR:
#6983
Quality Checklist
Code Review Reference
Please review our Branch & PR Standards before submitting. It explains the automated review flow, QA/DEV approval requirements, and what each label does — especially useful for first-time contributors.