feat: emoji superscroll#8793
Open
biotech77 wants to merge 9 commits into
Open
Conversation
Contributor
|
Windows and Mac build successful in Unity Cloud! You can find a link to the downloadable artifact below. |
github-actions
Bot
requested review from
Ludmilafantaniella,
NickKhalow and
mikhail-dcl
Contributor
Author
|
@claude review |
1 similar comment
Contributor
Author
|
@claude review |
|
✅ PR reviewed and approved by QA on both platforms following the PR test instructions. Build: Test results:
Unrelated errors noted (do not affect verdict):
Minor observation (non-blocking):
Verdict: PASS ✅ Evidence Mac 18.05.2026_10.54.57_REC.PR-8430.mp418.05.2026_10.30.51_REC.Pr.8430.mp4Windows: 18.05.2026_10.54.55_REC.PR.8430.mp4Tested by @DafGreco 20260518-1337-50.3728571.mp4 |
balducciv
approved these changes
May 18, 2026
Contributor
Author
|
@claude review |
Contributor
|
Claude Code is working… I'll analyze this and get back to you. |
…t/emoji-superscroll
sandrade-dcl
approved these changes
May 28, 2026
Comment on lines
+67
to
+75
| if (isVisible) | ||
| EnsureInitialized(); | ||
|
|
||
| if (!isVisible) | ||
| { | ||
| HideTooltip(); | ||
| view.BlurSearchInput(); | ||
| view.ClearSearchText(); | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| if (isVisible) | |
| EnsureInitialized(); | |
| if (!isVisible) | |
| { | |
| HideTooltip(); | |
| view.BlurSearchInput(); | |
| view.ClearSearchText(); | |
| } | |
| if (isVisible) | |
| EnsureInitialized(); | |
| else | |
| { | |
| HideTooltip(); | |
| view.BlurSearchInput(); | |
| view.ClearSearchText(); | |
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Solves: #8791
as a side effect it solves this as well #8430
What does this PR change?
Converts Emoji Panel to use item recycling with SuperScrollView that is used in project for recyclable lists and grids
Emoji panel works the same but it is much more efficient, no hard coded parts and much more simplified
Test Steps
OLD (when emoji panel opened)
OPTIMIZED (when emoji panel opened)
Quality Checklist
Code Review Reference
Please review our Branch & PR Standards before submitting. It explains the automated review flow, QA/DEV approval requirements, and what each label does — especially useful for first-time contributors.