feat: webgl ci cd

.github/workflows/build-unitycloud.yml

@@ -398,7 +398,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        target: ['windows64', 'macos']
+        target: ['windows64', 'macos', 'web']
     steps:
       - name: Checkout code
         uses: actions/checkout@v4
@@ -493,6 +493,18 @@ jobs:
             !build/**/*.pdb
           if-no-files-found: error
 
+      - name: Upload artifact for Web
+        id: upload-web-artifact
+        if: matrix.target == 'web'
+        uses: actions/upload-artifact@v4
+        with:
+          name: ${{ env.artifact_name }}
+          path: |
+            build
+            !build/**/*_BackUpThisFolder_ButDontShipItWithYourGame
+            !build/**/*_BurstDebugInformation_DoNotShip
+          if-no-files-found: error
+
       - name: Compress the build folder to upload it to S3
         run: |
           mkdir upload_to_s3/ && \
@@ -501,13 +513,16 @@ jobs:
           elif [ "${{ matrix.target }}" == "windows64" ]; then
             cd build
             zip -r ../upload_to_s3/${{ env.artifact_name }}.zip . -x "*_BackUpThisFolder_ButDontShipItWithYourGame**" -x "*_BurstDebugInformation_DoNotShip**" -x "*.pdb"
+          elif [ "${{ matrix.target }}" == "web" ]; then
+            cp -r build upload_to_s3/build
           fi
 
       - name: Install jq
         run: sudo apt-get update -y && sudo apt-get install -y jq
 
       - name: Enforce artifact size budget
         id: size_check
+        if: matrix.target != 'web'
         env:
           # Per-target absolute caps (MB)
           MAX_MACOS_MB: 450
@@ -672,17 +687,29 @@ jobs:
           AWS_ACCESS_KEY_ID: ${{ secrets.EXPLORER_TEAM_AWS_ACCESS_KEY_ID }}
           AWS_SECRET_ACCESS_KEY: ${{ secrets.EXPLORER_TEAM_AWS_SECRET_ACCESS_KEY }}
           EXPLORER_TEAM_S3_BUCKET: ${{ secrets.EXPLORER_TEAM_S3_BUCKET }}
-          DESTINATION_PATH: "${{
-            inputs.is_release_build && format('@dcl/{0}/releases/{1}', github.event.repository.name, inputs.tag_version)
-            || format('@dcl/{0}/branch/{1}/{2}-{3}-{4}', github.event.repository.name, env.SAFE_BRANCH_NAME, env.BUILD_PREFIX, github.run_number, env.SHA_SHORT)
-          }}"
+          EXPLORER_TEAM_S3_BUCKET_PUBLIC_URL: ${{ vars.EXPLORER_TEAM_S3_BUCKET_PUBLIC_URL }}
         run: |
+          set -euo pipefail
+
+          DESTINATION_PATH="${{ inputs.is_release_build && format('@dcl/{0}/releases/{1}', github.event.repository.name, inputs.tag_version) || format('@dcl/{0}/branch/{1}/{2}-{3}-{4}', github.event.repository.name, env.SAFE_BRANCH_NAME, env.BUILD_PREFIX, github.run_number, env.SHA_SHORT) }}"
+
+          # Latest dev build for webgl
+          if [ "${{ matrix.target }}" == "web" ] && [ "${GITHUB_REF_NAME}" == "dev" ]; then
+            DESTINATION_PATH="@dcl/${{ github.event.repository.name }}/dev/webgl-latest"
+          fi
+
+          if [ "${{ matrix.target }}" == "web" ]; then
+            echo "Web build link: $EXPLORER_TEAM_S3_BUCKET_PUBLIC_URL/$DESTINATION_PATH/build/Decentraland/index.html"
+          fi
+
           npx @dcl/cdn-uploader@next \
             --bucket $EXPLORER_TEAM_S3_BUCKET \
             --local-folder upload_to_s3 \
             --bucket-folder $DESTINATION_PATH
 
+      # web doesn't have debug symbols
       - name: Upload debug symbols
+        if: matrix.target != 'web'
         uses: actions/upload-artifact@v4
         with:
           name: ${{ env.artifact_name }}_debug_symbols
@@ -692,7 +719,7 @@ jobs:
           if-no-files-found: error
 
       - name: Upload debug symbols to Sentry
-        if: ${{ needs.prebuild.outputs.sentry_enabled == 'true' }}
+        if: ${{ needs.prebuild.outputs.sentry_enabled == 'true' && matrix.target != 'web' }}
         shell: bash
         env:
           SENTRY_AUTH_TOKEN: ${{ secrets.SENTRY_CLI_AUTH_TOKEN }}

.github/workflows/pr-comment-artifact-url.yml

@@ -122,6 +122,15 @@ jobs:
           echo "Mac Artifact ID: $MAC_ARTIFACT_ID"
           echo "MAC_ARTIFACT_ID=$MAC_ARTIFACT_ID" >> "$GITHUB_ENV"
 
+          WEB_ARTIFACT_ID=$(gh api "/repos/$OWNER/$REPO/actions/artifacts" \
+            --jq ".artifacts.[] |
+            select(.workflow_run.id==${PREVIOUS_JOB_ID}) |
+            select(.expired==false) |
+            select(.name==\"Decentraland_web\") |
+            .id")
+          echo "Web Artifact ID: $WEB_ARTIFACT_ID"
+          echo "WEB_ARTIFACT_ID=$WEB_ARTIFACT_ID" >> "$GITHUB_ENV"
+
           ORIGINAL_EVENT=$(jq -r '.event' <<< "$WORKFLOW_RUN_EVENT_OBJ")
           echo "Original Event: $ORIGINAL_EVENT"
 
@@ -208,6 +217,8 @@ jobs:
           WINDOWS_ARTIFACT_S3_URL: "${{ format('{0}/{1}/Decentraland_windows64.zip', vars.EXPLORER_TEAM_S3_BUCKET_PUBLIC_URL, env.ARTIFACT_S3_DESTINATION_PATH) }}"
           MAC_ARTIFACT_URL: "${{ github.server_url }}/${{ github.repository }}/suites/${{ env.SUITE_ID }}/artifacts/${{ env.MAC_ARTIFACT_ID }}"
           MAC_ARTIFACT_S3_URL: "${{ format('{0}/{1}/Decentraland_macos.zip', vars.EXPLORER_TEAM_S3_BUCKET_PUBLIC_URL, env.ARTIFACT_S3_DESTINATION_PATH) }}"
+          WEB_ARTIFACT_URL: "${{ github.server_url }}/${{ github.repository }}/suites/${{ env.SUITE_ID }}/artifacts/${{ env.WEB_ARTIFACT_ID }}"
+          WEB_ARTIFACT_S3_URL: "${{ format('{0}/{1}/build/Decentraland/index.html', vars.EXPLORER_TEAM_S3_BUCKET_PUBLIC_URL, env.ARTIFACT_S3_DESTINATION_PATH) }}"
           HEAD_SHA: "${{ env.HEAD_SHA }}"
         uses: peter-evans/create-or-update-comment@v3
         with:
@@ -217,7 +228,7 @@ jobs:
           body: |-
             ![badge]  <img src="https://ui.decentraland.org/decentraland_256x256.png" width="30">
 
-            Windows and Mac build successful in Unity Cloud! You can find a link to the downloadable artifact below.
+            Windows, Mac and Web build successful in Unity Cloud! You can find a link to the downloadable artifact below.
 
             | Name                | Link                    |
             | --------            | ----------------------- |
@@ -227,6 +238,8 @@ jobs:
             | Download Windows S3 | ${{ env.WINDOWS_ARTIFACT_S3_URL }} |
             | Download Mac        | ${{ env.MAC_ARTIFACT_URL }} |
             | Download Mac S3     | ${{ env.MAC_ARTIFACT_S3_URL }} |
+            | Download Web        | ${{ env.WEB_ARTIFACT_URL }} |
+            | Web Build on S3     | ${{ env.WEB_ARTIFACT_S3_URL }} |
             | Built on            | ${{ env.BUILD_DATE }} |
 
             ${{ env.SIZE_REPORT }}

Explorer/Assets/DCL/Infrastructure/CrdtEcsBridge/JsModulesImplementation/ClientWebSocketApiImplementation.cs

@@ -133,7 +133,7 @@ public async UniTask CloseAsync(int websocketId, CancellationToken ct)
                             text = Encoding.UTF8.GetString(result.Span),
                         };
 
-                    var binary = jsOperations.NewUint8Array(result.Length);
+                    IDCLTypedArray<byte> binary = jsOperations.NewUint8Array(result.Length);
                     binary.WriteBytes(result.Array, 0ul, (ulong)result.Length, 0ul);
 
                     return new IWebSocketApi.ReceiveResponse

Explorer/Assets/DCL/Infrastructure/CrdtEcsBridge/JsModulesImplementation/Communications/CommunicationsControllerAPIImplementationBase.cs

@@ -27,7 +27,7 @@ protected enum CommsMessageType {
         private readonly ISceneCommunicationPipe sceneCommunicationPipe;
         protected readonly IJsOperations jsOperations;
         private readonly ISceneCommunicationPipe.MsgType typeToHandle;
-        private readonly ScriptObject eventArray;
+        private readonly IDCLScriptObject eventArray;
         private readonly ISceneCommunicationPipe.SceneMessageHandler onMessageReceivedCached;
         private readonly ISceneData sceneData;
 
@@ -105,15 +105,15 @@ public ScriptObject GetResult()
                 for (var i = 0; i < eventsToProcess.Count; i++)
                 {
                     PoolableByteArray src = eventsToProcess[i];
-                    ITypedArray<byte> dst = jsOperations.GetTempUint8Array();
-                    dst.WriteBytes(src.Span, 0ul, (ulong)src.Length, 0ul);
+                    IDCLTypedArray<byte> dst = jsOperations.GetTempUint8Array();
+                    dst.WriteBytes(src.Array, 0ul, (ulong)src.Length, 0ul);
                     src.Dispose();
-                    object subArray = dst.InvokeMethod("subarray", 0, src.Length);
+                    object subArray = ((IDCLScriptObject)dst).InvokeMethod("subarray", 0, src.Length);
                     eventArray.SetProperty(i, subArray);
                 }
 
                 eventsToProcess.Clear();
-                return eventArray;
+                return (ScriptObject)eventArray.GetNativeObject();
             }
         }
 

Explorer/Assets/DCL/Infrastructure/CrdtEcsBridge/JsModulesImplementation/EngineAPIImplementation.cs

@@ -35,8 +35,10 @@ public class EngineAPIImplementation : IEngineApi
         private readonly CustomSampler deserializeBatchSampler;
         private readonly ISceneExceptionsHandler exceptionsHandler;
         private readonly IInstancePoolsProvider instancePoolsProvider;
+#if !UNITY_WEBGL
         private readonly MultiThreadSync multiThreadSync;
         private readonly MultiThreadSync.Owner syncOwner;
+#endif
         private readonly IOutgoingCRDTMessagesProvider outgoingCrtdMessagesProvider;
         private readonly CustomSampler outgoingMessagesSampler;
         private readonly ISystemGroupsUpdateGate systemGroupsUpdateGate;
@@ -53,9 +55,12 @@ public EngineAPIImplementation(
             ICRDTWorldSynchronizer crdtWorldSynchronizer,
             IOutgoingCRDTMessagesProvider outgoingCrtdMessagesProvider,
             ISystemGroupsUpdateGate systemGroupsUpdateGate,
-            ISceneExceptionsHandler exceptionsHandler,
-            MultiThreadSync multiThreadSync,
-            MultiThreadSync.Owner syncOwner)
+            ISceneExceptionsHandler exceptionsHandler
+#if !UNITY_WEBGL
+            ,MultiThreadSync multiThreadSync,
+            MultiThreadSync.Owner syncOwner
+#endif
+        )
         {
             sharedPoolsProvider = poolsProvider;
             this.instancePoolsProvider = instancePoolsProvider;
@@ -64,8 +69,10 @@ public EngineAPIImplementation(
             this.crdtSerializer = crdtSerializer;
             this.crdtWorldSynchronizer = crdtWorldSynchronizer;
             this.outgoingCrtdMessagesProvider = outgoingCrtdMessagesProvider;
+#if !UNITY_WEBGL
             this.multiThreadSync = multiThreadSync;
             this.syncOwner = syncOwner;
+#endif
             this.systemGroupsUpdateGate = systemGroupsUpdateGate;
             this.exceptionsHandler = exceptionsHandler;
 
@@ -248,7 +255,9 @@ private void ApplySyncCommandBuffer(IWorldSyncCommandBuffer worldSyncBuffer)
         {
             try
             {
+#if !UNITY_WEBGL
                 using MultiThreadSync.Scope mutex = multiThreadSync.GetScope(syncOwner);
+#endif
 
                 applyBufferSampler.Begin();
 

Explorer/Assets/DCL/Infrastructure/CrdtEcsBridge/JsModulesImplementation/RuntimeImplementation.cs

@@ -11,7 +11,6 @@
 using ECS.Prioritization.Components;
 using ECS.StreamableLoading.Common.Components;
 using ECS.StreamableLoading.Common.Systems;
-using Microsoft.ClearScript.JavaScript;
 using Newtonsoft.Json;
 using SceneRunner.Scene;
 using SceneRuntime;
@@ -63,23 +62,23 @@ public void Dispose() { }
 
             await UniTask.SwitchToMainThread();
 
-            async UniTask<StreamableLoadingResult<ITypedArray<byte>>> CreateFileRequestAsync(SubIntention intention, IAcquiredBudget budget, IPartitionComponent partition, CancellationToken ct)
+            async UniTask<StreamableLoadingResult<IDCLTypedArray<byte>>> CreateFileRequestAsync(SubIntention intention, IAcquiredBudget budget, IPartitionComponent partition, CancellationToken ct)
             {
                 using DownloadHandler? downloadHandler = await webRequestController.GetAsync(intention.CommonArguments.URL, ct, ReportCategory.JAVASCRIPT).ExposeDownloadHandlerAsync();
                 NativeArray<byte>.ReadOnly nativeBytes = downloadHandler.nativeData;
 
                 await DCLTask.SwitchToThreadPool();
 
                 // create script byte array
-                ITypedArray<byte> array = jsOperations.NewUint8Array(nativeBytes.Length);
+                IDCLTypedArray<byte> array = jsOperations.NewUint8Array(nativeBytes.Length);
 
                 // transfer data to script byte array
                 array.Write(nativeBytes, (ulong)nativeBytes.Length, 0);
-                return new StreamableLoadingResult<ITypedArray<byte>>(array);
+                return new StreamableLoadingResult<IDCLTypedArray<byte>>(array);
             }
 
             var intent = new SubIntention(new CommonLoadingArguments(url));
-            ITypedArray<byte> content = (await intent.RepeatLoopAsync(NoAcquiredBudget.INSTANCE, PartitionComponent.TOP_PRIORITY, CreateFileRequestAsync, ReportCategory.JAVASCRIPT, ct)).UnwrapAndRethrow();
+            IDCLTypedArray<byte> content = (await intent.RepeatLoopAsync(NoAcquiredBudget.INSTANCE, PartitionComponent.TOP_PRIORITY, CreateFileRequestAsync, ReportCategory.JAVASCRIPT, ct)).UnwrapAndRethrow();
 
             return new IRuntime.ReadFileResponse
             {

Explorer/Assets/DCL/Infrastructure/CrdtEcsBridge/JsModulesImplementation/SDKObservableEventsEngineAPIImplementation.cs

@@ -28,10 +28,17 @@ public class SDKObservableEventsEngineAPIImplementation : EngineAPIImplementatio
 
         public SDKObservableEventsEngineAPIImplementation(ISharedPoolsProvider poolsProvider, IInstancePoolsProvider instancePoolsProvider, ICRDTProtocol crdtProtocol, ICRDTDeserializer crdtDeserializer, ICRDTSerializer crdtSerializer,
             ICRDTWorldSynchronizer crdtWorldSynchronizer, IOutgoingCRDTMessagesProvider outgoingCrtdMessagesProvider,
-            ISystemGroupsUpdateGate systemGroupsUpdateGate, ISceneExceptionsHandler exceptionsHandler,
-            MultiThreadSync multiThreadSync, MultiThreadSync.Owner syncOwner) : base(poolsProvider, instancePoolsProvider, crdtProtocol,
+            ISystemGroupsUpdateGate systemGroupsUpdateGate, ISceneExceptionsHandler exceptionsHandler
+#if !UNITY_WEBGL
+            , MultiThreadSync multiThreadSync, MultiThreadSync.Owner syncOwner
+#endif
+        ) : base(poolsProvider, instancePoolsProvider, crdtProtocol,
             crdtDeserializer, crdtSerializer, crdtWorldSynchronizer, outgoingCrtdMessagesProvider,
-            systemGroupsUpdateGate, exceptionsHandler, multiThreadSync, syncOwner) { }
+            systemGroupsUpdateGate, exceptionsHandler
+#if !UNITY_WEBGL
+            , multiThreadSync, syncOwner
+#endif
+        ) { }
 
         public void TryAddSubscription(string eventId)
         {

Explorer/Assets/DCL/Infrastructure/CrdtEcsBridge/JsModulesImplementation/Tests/CommunicationControllerAPIImplementationShould.cs

@@ -6,7 +6,9 @@
 using DCL.Multiplayer.Connections.Messaging.Pipe;
 using ECS;
 using Microsoft.ClearScript;
+using Microsoft.ClearScript.JavaScript;
 using Microsoft.ClearScript.V8;
+using SceneRuntime.V8;
 using NSubstitute;
 using NUnit.Framework;
 using SceneRunner.Scene;
@@ -49,9 +51,9 @@ public void SetUp()
             var uint8ArrayCtor = (ScriptObject)engine.Global.GetProperty("Uint8Array");
 
             jsOperations = Substitute.For<IJsOperations>();
-            jsOperations.NewArray().Returns(_ => arrayCtor.Invoke(true));
+            jsOperations.NewArray().Returns(_ => new V8ScriptObjectAdapter((ScriptObject)arrayCtor.Invoke(true)));
 
-            jsOperations.GetTempUint8Array().Returns(_ => uint8ArrayCtor.Invoke(true, IJsOperations.LIVEKIT_MAX_SIZE));
+            jsOperations.GetTempUint8Array().Returns(_ => new V8TypedArrayAdapter((ITypedArray<byte>)uint8ArrayCtor.Invoke(true, IJsOperations.LIVEKIT_MAX_SIZE)));
 
             api = new CommunicationsControllerAPIImplementation(
                     sceneData,

Explorer/Assets/DCL/Infrastructure/CrdtEcsBridge/JsModulesImplementation/Tests/EngineAPIImplementationShould.cs

@@ -77,8 +77,13 @@ public void SetUp()
                 crdtWorldSynchronizer = Substitute.For<ICRDTWorldSynchronizer>(),
                 outgoingCrtdMessagesProvider = Substitute.For<IOutgoingCRDTMessagesProvider>(),
                 Substitute.For<ISystemGroupsUpdateGate>(),
-                new RethrowSceneExceptionsHandler(),
-                new MultiThreadSync(new SceneShortInfo()), new MultiThreadSync.Owner("TEST"));
+                new RethrowSceneExceptionsHandler()
+#if !UNITY_WEBGL
+                ,
+                new MultiThreadSync(new SceneShortInfo()),
+                new MultiThreadSync.Owner("TEST")
+#endif
+                );
 
             crdtDeserializer.When(d => d.DeserializeBatch(ref Arg.Any<ReadOnlyMemory<byte>>(), Arg.Any<IList<CRDTMessage>>()))
                             .Do(c =>

Explorer/Assets/DCL/Infrastructure/CrdtEcsBridge/PoolsProviders/InstancePoolsProviderExtensions.cs

@@ -1,11 +1,11 @@
-using Microsoft.ClearScript.JavaScript;
+using Utility;
 
 namespace CrdtEcsBridge.PoolsProviders
 {
     public static class InstancePoolsProviderExtensions
     {
         public static void RenewCrdtRawDataPoolFromScriptArray(
-            this IInstancePoolsProvider instancePoolsProvider, ITypedArray<byte> scriptArray,
+            this IInstancePoolsProvider instancePoolsProvider, IDCLTypedArray<byte> scriptArray,
             ref PoolableByteArray lastInput)
         {
             EnsureArrayLength(instancePoolsProvider, (int)scriptArray.Length, ref lastInput);