Skip to content

chore: claude bot PR comments deduplication#8620

Draft
pravusjif wants to merge 6 commits into
devfrom
chore/deduplicate-claude-review-comments
Draft

chore: claude bot PR comments deduplication#8620
pravusjif wants to merge 6 commits into
devfrom
chore/deduplicate-claude-review-comments

Conversation

@pravusjif
Copy link
Copy Markdown
Member

Added cleanup logic for previous Claude comments in the review process.

Added cleanup logic for previous Claude comments in the review process.

Signed-off-by: Pravus <pravusjif@gmail.com>
@pravusjif pravusjif self-assigned this May 5, 2026
@pravusjif pravusjif added the no QA needed Used to tag pull requests that does not require QA validation label May 5, 2026
@pravusjif pravusjif moved this from Todo to In Progress in Explorer Alpha May 5, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2026

badge

New build in progress, come back later!

@pravusjif pravusjif marked this pull request as ready for review May 5, 2026 15:53
@pravusjif pravusjif requested review from a team as code owners May 5, 2026 15:53
@pravusjif pravusjif changed the title chore: PR claude bot comments deduplication chore: claude bot PR comments deduplication May 5, 2026
@pravusjif
Copy link
Copy Markdown
Member Author

@claude review

Comment thread .github/workflows/claude-pr-review.yml Outdated
Comment thread .github/workflows/claude-pr-review.yml Outdated
Comment thread .github/workflows/claude-pr-review.yml Outdated
Comment thread .github/workflows/claude-pr-review.yml Outdated
pravusjif and others added 4 commits May 6, 2026 14:07
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
Signed-off-by: Pravus <pravusjif@gmail.com>
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
Signed-off-by: Pravus <pravusjif@gmail.com>
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
Signed-off-by: Pravus <pravusjif@gmail.com>
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
Signed-off-by: Pravus <pravusjif@gmail.com>
@pravusjif
Copy link
Copy Markdown
Member Author

@claude review

@claude
Copy link
Copy Markdown
Contributor

claude Bot commented May 6, 2026

Claude finished @pravusjif's task in 47s —— View job


Review: chore/deduplicate-claude-review-comments

Root cause: Duplicate Claude review comments accumulate when multiple review runs happen on the same PR. The diff adds cleanup logic that deletes prior Claude review comments after each run. This addresses the cause directly.

The two issues raised in the prior review have been fixed in follow-up commits:

  • [...comments.data].filter(...) — no longer mutates comments.data in place after the earlier .reverse() call (lines 110, 323).
  • c.body?.includes('REVIEW_RESULT:') guard — only previous review comments are deleted now; ad-hoc @claude explain/question responses are preserved (lines 112, 325).

Both cleanup blocks (lines 109–124 and 322–337) are symmetric and correct. Errors during deletion are caught and logged, so a single failure won't break the rest of the workflow.

No further blocking issues.

REVIEW_RESULT: PASS ✅
COMPLEXITY: SIMPLE
COMPLEXITY_REASON: Touches only one CI/CD workflow file; no runtime code changes.
QA_REQUIRED: NO
Branch

@github-actions github-actions Bot deleted a comment from claude Bot May 6, 2026
@pravusjif
Copy link
Copy Markdown
Member Author

@claude review

@claude
Copy link
Copy Markdown
Contributor

claude Bot commented May 6, 2026

Claude finished @pravusjif's task in 38s —— View job


Review: chore/deduplicate-claude-review-comments

Root cause: Duplicate Claude review comments accumulate when multiple review runs happen on the same PR. The diff adds cleanup logic that deletes prior Claude review comments after each run. This fixes the cause directly.

Prior review feedback — both addressed:

  • [...comments.data].filter(...) (lines 109, 322) — copies before filtering, no in-place mutation after the earlier .reverse().
  • c.body?.includes('REVIEW_RESULT:') guard (lines 112, 325) — only previous review comments are deleted; ad-hoc @claude explain/question responses are preserved.

Both cleanup blocks are symmetric. Errors during deletion are caught and logged, so a single failure won't break the rest of the workflow. Self-deletion is correctly prevented via c.id !== claudeComment.id.

Note: Comments from failed reviews (no REVIEW_RESULT: marker) intentionally persist for debugging — likely desired, no change needed.

No blocking issues.

  • Read changed workflow file
  • Verify prior review feedback was addressed
  • Check for new issues
  • Post review

REVIEW_RESULT: PASS ✅
COMPLEXITY: SIMPLE
COMPLEXITY_REASON: Touches only one CI/CD workflow file; no runtime code changes.
QA_REQUIRED: NO

Branch

@pravusjif pravusjif marked this pull request as draft May 14, 2026 14:45
@pravusjif pravusjif removed the status in Explorer Alpha May 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do not merge no QA needed Used to tag pull requests that does not require QA validation

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants