-
Notifications
You must be signed in to change notification settings - Fork 111
Modernize packaging: migrate setup.py to PEP 621 pyproject.toml #645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,77 @@ | ||
| [build-system] | ||
| requires = ["setuptools>=68", "wheel"] | ||
| build-backend = "setuptools.build_meta" | ||
|
|
||
| [project] | ||
| name = "dbt-sqlserver" | ||
| description = "A Microsoft SQL Server adapter plugin for dbt" | ||
| readme = "README.md" | ||
| license = { text = "MIT" } | ||
| authors = [ | ||
| { name = "Mikael Ene" }, | ||
| { name = "Anders Swanson" }, | ||
| { name = "Sam Debruyn" }, | ||
| { name = "Cor Zuurmond" }, | ||
| { name = "Cody Scott" }, | ||
| ] | ||
| requires-python = ">=3.10" | ||
| classifiers = [ | ||
| "Development Status :: 5 - Production/Stable", | ||
| "License :: OSI Approved :: MIT License", | ||
| "Operating System :: Microsoft :: Windows", | ||
| "Operating System :: MacOS :: MacOS X", | ||
| "Operating System :: POSIX :: Linux", | ||
| "Programming Language :: Python :: 3.10", | ||
| "Programming Language :: Python :: 3.11", | ||
| "Programming Language :: Python :: 3.12", | ||
| "Programming Language :: Python :: 3.13", | ||
| ] | ||
| dependencies = [ | ||
| "dbt-core>=1.9.0,<2.0", | ||
| "dbt-common>=1.0,<2.0", | ||
| "dbt-adapters>=1.11.0,<2.0", | ||
| "pyodbc>=4.0.35,<5.2.0", | ||
| ] | ||
| dynamic = ["version"] | ||
|
|
||
| [project.optional-dependencies] | ||
| azure = [ | ||
| "azure-identity>=1.12.0", | ||
| ] | ||
| dev = [ | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we want people to be able to do dbt-sqlserver[dev] to install? Would it make more sense to put these into dependency-groups so that consumers of the package can't install the dev stuff, people developing could do uv sync --group dev?
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this is the correct structure example: [dependency-groups] |
||
| "dbt-tests-adapter>=1.9.0,<2.0", | ||
| "azure-identity>=1.12.0", | ||
| "build", | ||
| "bumpversion", | ||
| "flaky", | ||
| "freezegun==1.4.0", | ||
| "ipdb", | ||
| "mypy==1.11.2", | ||
| "pre-commit", | ||
| "pytest", | ||
| "pytest-csv", | ||
| "pytest-dotenv", | ||
| "pytest-xdist", | ||
| "pytz", | ||
| "ruff", | ||
| "tox>=3.13", | ||
| "twine", | ||
| ] | ||
|
|
||
| [project.urls] | ||
| "Setup & configuration" = "https://docs.getdbt.com/reference/warehouse-profiles/mssql-profile" | ||
| "Documentation & usage" = "https://docs.getdbt.com/reference/resource-configs/mssql-configs" | ||
| "Changelog" = "https://github.com/dbt-msft/dbt-sqlserver/blob/master/CHANGELOG.md" | ||
| "Issue Tracker" = "https://github.com/dbt-msft/dbt-sqlserver/issues" | ||
| "Source" = "https://github.com/dbt-msft/dbt-sqlserver" | ||
|
|
||
| [tool.setuptools.dynamic] | ||
| version = { attr = "dbt.adapters.sqlserver.__version__.version" } | ||
|
|
||
| [tool.setuptools.packages.find] | ||
| include = ["dbt", "dbt.*"] | ||
| namespaces = true | ||
|
|
||
| [tool.setuptools.package-data] | ||
| "dbt" = ["include/**/*.sql", "include/**/*.yml", "include/**/*.md"] | ||
| "dbt.adapters.sqlserver" = ["py.typed"] | ||
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we move this python script to an actual script rather than inline? Right now this python code can't get tested or go through our normal python pre-commit steps.