Skip to content

dbeaver/pro#9880 updates isChanged with isReadonly flag to fix the form flow - #4535

Open
sergeyteleshev wants to merge 5 commits into
develfrom
9880-project-profiles---no-pop-up-with-unsaved-creds-unnecessary-save-changes-pop-up
Open

dbeaver/pro#9880 updates isChanged with isReadonly flag to fix the form flow#4535
sergeyteleshev wants to merge 5 commits into
develfrom
9880-project-profiles---no-pop-up-with-unsaved-creds-unnecessary-save-changes-pop-up

Conversation

@sergeyteleshev

@sergeyteleshev sergeyteleshev commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

closes https://github.com/dbeaver/pro/issues/9880

What happened:
When we load the Profile Network Part we apply for all handlers the state and isReadonly flag so user is unable to edit anything (since profile is applied)

https://github.com/dbeaver/cloudbeaver-ee/blob/c7a40e0500ea37d85d0641982f9ec17ec50342df/webapp/packages/plugin-network-profiles/src/ConnectionForm/ConnectionFormNetworkProfilePart.ts#L115

By doing so we actually modify parts state (SSH in our case). Which makes isChanged = true. Following that when we close the form we see warning modal window that something has changed, but in fact it is not and unexpected behavior

So my suggestion is to consider form part not being modified at all, if parts are in readonly mode. The changes affects only SSH tab since it is only there this new flag isReadonly present right now

@sergeyteleshev sergeyteleshev self-assigned this Aug 7, 2026
@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity

Metric Results
Complexity 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants