dbeaver/pro#9880 updates isChanged with isReadonly flag to fix the form flow - #4535
Open
sergeyteleshev wants to merge 5 commits into
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
…x the form flow" This reverts commit 69ab0b0.
…nnectionFormSSHPart
…ved-creds-unnecessary-save-changes-pop-up
devnaumov
approved these changes
Aug 7, 2026
…ved-creds-unnecessary-save-changes-pop-up
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes https://github.com/dbeaver/pro/issues/9880
What happened:
When we load the Profile Network Part we apply for all handlers the state and
isReadonlyflag so user is unable to edit anything (since profile is applied)https://github.com/dbeaver/cloudbeaver-ee/blob/c7a40e0500ea37d85d0641982f9ec17ec50342df/webapp/packages/plugin-network-profiles/src/ConnectionForm/ConnectionFormNetworkProfilePart.ts#L115
By doing so we actually modify parts state (SSH in our case). Which makes
isChanged = true. Following that when we close the form we see warning modal window that something has changed, but in fact it is not and unexpected behaviorSo my suggestion is to consider form part not being modified at all, if parts are in readonly mode. The changes affects only SSH tab since it is only there this new flag
isReadonlypresent right now