4551 generate full ddl for postgresql metaobjects - #4507
Open
sergeyteleshev wants to merge 12 commits into
Open
Conversation
…L" action into data editor footer for DDL properties tab
…f connection doesn't support it
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 31 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
sergeyteleshev
marked this pull request as ready for review
July 29, 2026 11:26
SychevAndrey
requested changes
Aug 3, 2026
Comment on lines
+61
to
+83
| async function loadDdl(showFullDdl: boolean) { | ||
| if (!ddlGenerator) { | ||
| return; | ||
| } | ||
|
|
||
| setDdlLoading(true); | ||
| try { | ||
| const newQuery = await sqlGeneratorsResource.resource.generateEntityQuery(ddlGenerator.id, nodeId, { | ||
| ...getDefaultQueryGeneratorOptions(), | ||
| showFullDdl, | ||
| }); | ||
| setQuery(newQuery); | ||
| } catch (error: any) { | ||
| notificationService.logException(error, 'plugin_ddl_viewer_full_ddl_error_title'); | ||
| } finally { | ||
| setDdlLoading(false); | ||
| } | ||
| } | ||
|
|
||
| useEffect(() => { | ||
| if (ddlGenerator) { | ||
| loadDdl(isFullDdl); | ||
| } |
Contributor
There was a problem hiding this comment.
looks like it should be a separate resource or at least a part of SqlGeneratorsResource.
Contributor
Author
There was a problem hiding this comment.
nice catch! moved it to a separate resource so we can reuse its all features we need in this component
SychevAndrey
previously approved these changes
Aug 4, 2026
…ted files; migrate SQL generation logic to plugin-sql-generator
…DDL viewer context
devnaumov
reviewed
Aug 6, 2026
devnaumov
previously approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes https://github.com/dbeaver/pro/issues/4551
metadataGetNodeDDL&sqlGenerateEntityQuery- these queries basically do the same, so backend introducedasyncSqlGenerateEntityQuery(which allows to get heavy queries as well) and we need to use only it so we don't have any code & logic duplicationsalso I have introduced new plugin
core-sql-generatorand moved the resource there so we don't have to importplugin-sql-generatorintoplugin-ddl-viewer. these 2 plugins already have enough deps withsql-editoranddata-editor. by that we reduce probability of a circular deps plugins import in the future