Skip to content

Add asset and component api - #57

Open
shentuzhigang wants to merge 13 commits into
datadrivers:mainfrom
shentuzhigang:master
Open

Add asset and component api#57
shentuzhigang wants to merge 13 commits into
datadrivers:mainfrom
shentuzhigang:master

Conversation

@shentuzhigang

Copy link
Copy Markdown

i add some new api

Comment thread asset.go Outdated
Comment thread asset.go Outdated
Comment thread asset.go Outdated
Comment thread asset.go Outdated
Comment thread asset_test.go
@@ -0,0 +1 @@
package client

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please create tests

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests for all functions

Comment thread component.go Outdated
Comment thread component.go Outdated
Comment thread component.go Outdated
Comment thread component.go
}

func (c client) ComponentUpload(s string, component Component) error {
panic("implement me")

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please implement

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please implement the logic or remove the function

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests for all functions

Comment thread component_test.go
Comment thread asset_test.go
@@ -0,0 +1 @@
package client

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests for all functions

Comment thread component.go
}

func (c client) ComponentUpload(s string, component Component) error {
panic("implement me")

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please implement the logic or remove the function

Comment thread component.go
}

func (c client) ComponentUpload(s string, component Component) error {
panic("implement me")

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests for all functions

@anmoel anmoel changed the title Add repository list And component api Add asset and component api Jan 3, 2022
Comment thread go.mod
@@ -1,9 +1,9 @@
module github.com/datadrivers/go-nexus-client
module github.com/shentuzhigang/nexus-client-go

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove this change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants