Index slim client and provider snapshots on DOIs

[jrhoads]

Purpose

DOI OpenSearch documents should store only the client and provider fields needed for search and include=client / include=provider, instead of the full associated JSON.

Approach

• Replace client.as_indexed_json and provider.as_indexed_json on a DOI with explicit snapshots.
• Keep is_active on both snapshots. ClientSerializer and ProviderSerializer call is_active.getbyte when those relationships are included.

Key Modifications

• app/models/doi.rb: Added doi_client_indexed_json and doi_provider_indexed_json, and used them from as_indexed_json.
• spec/models/doi_spec.rb: The snapshot example uses a supported certificate (CoreTrustSeal), an integer opendoar_id, and expects is_active on both snapshots.

Important Technical Details

• GET /dois?include=client serializes the client embedded in the DOI document. Omitting is_active makes that request return 400 (undefined method 'getbyte' for nil).
• client.opendoar_id is an integer column, so the indexed value is an integer.
• Client#check_certificate only allows the supported certificate names, including CoreTrustSeal.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

• Be humble in the language and feedback you give, ask don't tell.
• Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
• Offer suggestions on how to improve code e.g. simplification or expanding clarity.
• Ensure you give reasons for the changes you are proposing.