Skip to content

add new column for annual revenue field - #1600

Open
bklaing2 wants to merge 4 commits into
masterfrom
add-annual-revenue-field
Open

bklaing2 wants to merge 4 commits into
masterfrom
add-annual-revenue-field

Conversation

@bklaing2

@bklaing2 bklaing2 commented Sep 30, 2026 •

Copy link
Copy Markdown
Member

Purpose

Adds the new column annual_revenue to the providers table. Returns the annual revenue in the API if the user has that ability. Annual revenue is included in provider.to_api, and is sent to Salesforce.

Adds a new one-off rake task to backfill the existing values for annual revenue from Salesforce after the column is added.

closes: https://github.com/datacite/product-backlog/issues/899

Approach

Open Questions and Pre-Merge TODOs

Learning

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

@bklaing2
bklaing2 force-pushed the add-annual-revenue-field branch from 0716a09 to e446360 Compare October 15, 2026 12:45
@bklaing2
bklaing2 marked this pull request as ready for review October 15, 2026 13:56
@jrhoads

jrhoads commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

Overall good but we should make sure this doesn't show up a the audit endpoint

I saw that there was an exclusion on the serialization based on the ability to view billing information.

Exclude annual_revenue from auditing, as billing_information already is, or apply equivalent permissions to activity changes.

@bklaing2
bklaing2 force-pushed the add-annual-revenue-field branch from 015c3b3 to 5882316 Compare October 22, 2026 23:51
Comment thread spec/models/activity_spec.rb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants