Repository navigation
Conversation
bklaing2
force-pushed
the
add-annual-revenue-field
branch
from
October 15, 2026 12:45
0716a09 to
e446360
Compare
bklaing2
marked this pull request as ready for review
October 15, 2026 13:56
Contributor
|
Overall good but we should make sure this doesn't show up a the audit endpoint I saw that there was an exclusion on the serialization based on the ability to view billing information. Exclude annual_revenue from auditing, as billing_information already is, or apply equivalent permissions to activity changes. |
bklaing2
force-pushed
the
add-annual-revenue-field
branch
from
October 22, 2026 23:51
015c3b3 to
5882316
Compare
jrhoads
reviewed
Oct 23, 2026
jrhoads
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Adds the new column
annual_revenueto the providers table. Returns the annual revenue in the API if the user has that ability. Annual revenue is included inprovider.to_api, and is sent to Salesforce.Adds a new one-off rake task to backfill the existing values for annual revenue from Salesforce after the column is added.
closes: https://github.com/datacite/product-backlog/issues/899
Approach
Open Questions and Pre-Merge TODOs
Learning
Types of changes
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Reviewer, please remember our guidelines: