Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The recursion guard permanently suppresses later URL synchronization on reused DOI instances.
Review effort: Balanced
Findings: 1
What changed in this PR
Fixes DOI registration dates being indexed before persistence.
Changes:
- Updates handle URLs before queuing DOI indexing.
- Reloads DOI data before Elasticsearch indexing.
- Adds regression coverage for registration ordering.
| File | Description |
|---|---|
app/models/doi.rb |
Adds URL-update recursion guard. |
app/models/concerns/indexable.rb |
Updates URL before enqueueing indexing. |
app/jobs/index_job_doi_registration.rb |
Reloads DOI before indexing. |
spec/concerns/indexable_spec.rb |
Tests registration ordering. |
spec/jobs/index_job_doi_registration_spec.rb |
Tests fresh registration data indexing. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+2132
to
+2134
| return if @updating_url | ||
|
|
||
| @updating_url = true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Purpose
closes: datacite/datacite#2512
Approach
Open Questions and Pre-Merge TODOs
Learning
Types of changes
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Reviewer, please remember our guidelines: